From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752160AbbBVKjp (ORCPT ); Sun, 22 Feb 2015 05:39:45 -0500 Received: from smtprelay0096.hostedemail.com ([216.40.44.96]:39810 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751805AbbBVKjl (ORCPT ); Sun, 22 Feb 2015 05:39:41 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:334:355:368:369:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3874:4321:4605:5007:6261:10004:10400:10848:10967:11026:11232:11658:11914:12296:12517:12519:12740:13069:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: cows60_54597b6eb3649 X-Filterd-Recvd-Size: 2175 Message-ID: <1424601578.20944.12.camel@perches.com> Subject: Re: [PATCH 24/27] tracing: Remove use of seq_printf return value From: Joe Perches To: Al Viro Cc: Steven Rostedt , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Date: Sun, 22 Feb 2015 02:39:38 -0800 In-Reply-To: <20150222044144.GD29656@ZenIV.linux.org.uk> References: <175dfb0fba2847cb32fb4c9bb1d3f89643993414.1424573328.git.joe@perches.com> <20150221225409.417968db@grimm.local.home> <20150222044144.GD29656@ZenIV.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-02-22 at 04:41 +0000, Al Viro wrote: > On Sat, Feb 21, 2015 at 10:54:09PM -0500, Steven Rostedt wrote: > > On Sat, 21 Feb 2015 18:53:51 -0800 Joe Perches wrote: > > > > > The seq_printf return value, because it's frequently misused, > > > will eventually be converted to void. > > > > > > See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to > > > seq_has_overflowed() and make public") > > > > > > Miscellanea: > > > > > > o Remove unused return value from trace_lookup_stack > > > > Acked-by: Steven Rostedt > > FWIW, this one should be Cc:stable - it's a plain and simple bugfix > (so are all of those that used to return the result of seq_printf() from > ->show()). Nah, it's not really a bugfix here. Patches sent to stable should fix actual bugs or failures. Sure, it's a defect, but it's only a logical one, not an actual one. It doesn't/can't fail in practice. This is only a single symbol and so it can't overflow the initial allocation. Besides that, the return value of the containing function is ignored.