All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrien Schildknecht <adrien+dev@schischi.me>
To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, srostedt@redhat.com, luto@amacapital.net,
	adrien+dev@schischi.me, rostedt@goodmis.org, bp@alien8.de,
	linux-kernel@vger.kernel.org
Subject: [PATCH] x86_64: use kstack_end() in dumpstack_64.c
Date: Sun, 22 Feb 2015 16:23:58 +0100	[thread overview]
Message-ID: <1424618638-6375-1-git-send-email-adrien+dev@schischi.me> (raw)

i386 is already using kstack_end() in dumpstack_32.c.
We should also use it to make the code clearer and unify the stack
printing logic some more.

This patch depends on patch "x86: fix output of show_stack_log_lvl()"

Signed-off-by: Adrien Schildknecht <adrien+dev@schischi.me>
---
 arch/x86/kernel/dumpstack_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/dumpstack_64.c b/arch/x86/kernel/dumpstack_64.c
index 553573b..5f1c626 100644
--- a/arch/x86/kernel/dumpstack_64.c
+++ b/arch/x86/kernel/dumpstack_64.c
@@ -280,7 +280,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
 				pr_cont(" <EOI> ");
 			}
 		} else {
-		if (((long) stack & (THREAD_SIZE-1)) == 0)
+		if (kstack_end(stack))
 			break;
 		}
 		if ((i % STACKSLOTS_PER_LINE) == 0) {
-- 
2.2.1


             reply	other threads:[~2015-02-22 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22 15:23 Adrien Schildknecht [this message]
2015-02-23 17:17 ` [PATCH] x86_64: use kstack_end() in dumpstack_64.c Steven Rostedt
2015-02-23 17:20   ` Borislav Petkov
2015-02-23 17:29   ` Adrien Schildknecht
2015-02-23 17:54     ` Steven Rostedt
2015-02-23 18:02 ` Borislav Petkov
2015-03-03 11:28 ` [tip:x86/debug] x86/kernel: Use " tip-bot for Adrien Schildknecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424618638-6375-1-git-send-email-adrien+dev@schischi.me \
    --to=adrien+dev@schischi.me \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.