From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56745) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPu1f-0007XL-2C for qemu-devel@nongnu.org; Mon, 23 Feb 2015 09:30:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPu1S-0003bC-09 for qemu-devel@nongnu.org; Mon, 23 Feb 2015 09:30:23 -0500 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:56918 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPu1R-0003Xz-ML for qemu-devel@nongnu.org; Mon, 23 Feb 2015 09:30:09 -0500 From: Peter Lieven Date: Mon, 23 Feb 2015 15:27:39 +0100 Message-Id: <1424701661-21241-4-git-send-email-pl@kamp.de> In-Reply-To: <1424701661-21241-1-git-send-email-pl@kamp.de> References: <1424701661-21241-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCH 3/5] vpc: Ignore geometry for large images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, carnold@suse.com, jcody@redhat.com, mreitz@redhat.com, stefanha@redhat.com From: Kevin Wolf The CHS calculation as done per the VHD spec imposes a maximum image size of ~127 GB. Real VHD images exist that are larger than that. Apparently there are two separate non-standard ways to achieve this: You could use more heads than the spec does - this is the option that qemu-img create chooses. However, other images exist where the geometry is set to the maximum (65536/16/255), but the actual image size is larger. Until now, such images are truncated at 127 GB when opening them with qemu. This patch changes the vpc driver to ignore geometry in this case and only trust the size field in the header. Signed-off-by: Kevin Wolf --- block/vpc.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 4e5ba85..11d3c86 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -215,12 +215,10 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags, bs->total_sectors = (int64_t) be16_to_cpu(footer->cyls) * footer->heads * footer->secs_per_cyl; - /* images created with disk2vhd report a far higher virtual size - * than expected with the cyls * heads * sectors_per_cyl formula. - * use the footer->size instead if the image was created with - * disk2vhd. - */ - if (!strncmp(footer->creator_app, "d2v", 4)) { + /* Images that have exactly the maximum geometry are probably bigger and + * would be truncated if we adhered to the geometry for them. Rely on + * footer->size for them. */ + if (bs->total_sectors == 65535ULL * 16 * 255) { bs->total_sectors = be64_to_cpu(footer->size) / BDRV_SECTOR_SIZE; } -- 1.7.9.5