From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Subject: Re: [PATCH V4 2/2] spmi: pmic_arb: add support for hw version 2
Date: Mon, 23 Feb 2015 18:06:10 +0200
Message-ID: <1424707570.2340.9.camel@mm-sol.com>
References: <1424386453-18092-1-git-send-email-gavidov@codeaurora.org>
	 <1424386453-18092-3-git-send-email-gavidov@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from ns.mm-sol.com ([37.157.136.199]:42899 "EHLO extserv.mm-sol.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752351AbbBWQGP (ORCPT <rfc822;linux-arm-msm@vger.kernel.org>);
	Mon, 23 Feb 2015 11:06:15 -0500
In-Reply-To: <1424386453-18092-3-git-send-email-gavidov@codeaurora.org>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Gilad Avidov <gavidov@codeaurora.org>
Cc: sdharia@codeaurora.org, mlocke@codeaurora.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, galak@codeaurora.org, agross@codeaurora.org


Hi Gilad, 

On Thu, 2015-02-19 at 15:54 -0700, Gilad Avidov wrote:

> 
> +
> +static u32 pmic_arb_fmt_cmd_v1(u8 opc, u8 sid, u16 addr, u8 bc)
> +{
> +       return (opc << 27) | ((sid & 0xf) << 20) | (addr << 4) | (bc & 0x7);
> +}
> +
> +static u32 pmic_arb_fmt_cmd_v2(u8 opc, u8 sid, u16 addr, u8 bc)
> +{
> +       return (opc << 27) | ((addr & 0xff) << 4) | (bc & 0x7);

This one is looking suspicious. Address could be only 8 bits? Slave ID is not used?

Is this correct?

Ivan