From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 3/7] sysctl: Make topologyinfo and numainfo sysctls a little more efficient Date: Mon, 23 Feb 2015 16:40:53 +0000 Message-ID: <1424709653.27930.212.camel__35649.5673455813$1424709759$gmane$org@citrix.com> References: <1423512275-6531-1-git-send-email-boris.ostrovsky@oracle.com> <1423512275-6531-4-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423512275-6531-4-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky Cc: wei.liu2@citrix.com, ufimtseva@gmail.com, port-xen@netbsd.org, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-02-09 at 15:04 -0500, Boris Ostrovsky wrote: > Currently both of these sysctls make a copy to userspace for each index of > various query arrays. We should try to copy whole arrays instead. > > This requires some changes in sysctl's public data structure, thus bump > interface version. > > Report topology for all present (not just online) cpus. > > Rename xen_sysctl_topologyinfo and XEN_SYSCTL_topologyinfo to reflect the fact > that these are used for CPU topology. Subsequent patch will add support for > PCI topology sysctl. > > Clarify some somments in sysctl.h. > > Signed-off-by: Boris Ostrovsky Was there a significant change in v3 which invalidated my tools ack from <1421688368.10440.171.camel@citrix.com>? Per-patch changelogs (after the ---) are very helpful for this sort of thing.