From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752576AbbBWRbR (ORCPT ); Mon, 23 Feb 2015 12:31:17 -0500 Received: from mailrelay103.isp.belgacom.be ([195.238.20.130]:38378 "EHLO mailrelay103.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbbBWRbQ (ORCPT ); Mon, 23 Feb 2015 12:31:16 -0500 X-Belgacom-Dynamic: yes X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=ZT6Ny9SzQUL0U4sOn6xM6rLbT25dGdPOAe/imaXRw80= c=1 sm=2 a=JfrnYn6hAAAA:8 a=o09OCNGhG82nF0a4kssA:9 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CqDQA3Y+tU/ykCtFtbgwaBLLA1BQEBAQEBAQUBd5dNgSREAQEBAQEBfIQ9LyOBGjeIMwHAdZIvLIYHiRZkHYQVBZkVim6IRSKBRQE8HBSBPT0xgQKBQQEBAQ From: Fabian Frederick To: linux-kernel@vger.kernel.org Cc: davem@davemloft.net, Peter Zijlstra , Fabian Frederick , netdev@vger.kernel.org Subject: [PATCH 1/1 net-next] net/atm/signaling.c: replace current->state by __set_current_state() Date: Mon, 23 Feb 2015 18:31:07 +0100 Message-Id: <1424712667-11849-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use helper functions to access current->state. Direct assignments are prone to races and therefore buggy. Thanks to Peter Zijlstra for the exact definition of the problem. Suggested-By: Peter Zijlstra Signed-off-by: Fabian Frederick --- net/atm/signaling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/atm/signaling.c b/net/atm/signaling.c index 523bce7..0140832 100644 --- a/net/atm/signaling.c +++ b/net/atm/signaling.c @@ -40,7 +40,7 @@ static void sigd_put_skb(struct sk_buff *skb) pr_debug("atmsvc: waiting for signaling daemon...\n"); schedule(); } - current->state = TASK_RUNNING; + __set_current_state(TASK_RUNNING); remove_wait_queue(&sigd_sleep, &wait); #else if (!sigd) { -- 2.1.0