From: "Gregory M. Turner" <gmt@be-evil.net>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org, "Gregory M. Turner" <gmt@be-evil.net>
Subject: [PATCH v2(sorta) 2/2] bluetooth: l2cap_core: ratelimit continuation frame printk
Date: Mon, 23 Feb 2015 22:25:41 -0800 [thread overview]
Message-ID: <1424759141-17889-3-git-send-email-gmt@be-evil.net> (raw)
In-Reply-To: <1424759141-17889-1-git-send-email-gmt@be-evil.net>
Some(1) users with semi-broken dongles (?) get storms of "Unexpected
continuation frame (len 0)" messages flooding their logs. So ratelimit
this printk.
(1)
https://bugs.launchpad.net/ubuntu/+source/bluetooth-alsa/+bug/192502
https://bugzilla.kernel.org/show_bug.cgi?id=11705
https://bugzilla.redhat.com/show_bug.cgi?id=450490
Signed-off-by: Gregory M. Turner <gmt@be-evil.net>
---
net/bluetooth/l2cap_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 6ba33f9..7090aa0 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -7493,7 +7493,7 @@ int l2cap_recv_acldata(struct hci_conn *hcon, struct sk_buff *skb, u16 flags)
BT_DBG("Cont: frag len %d (expecting %d)", skb->len, conn->rx_len);
if (!conn->rx_len) {
- BT_ERR("Unexpected continuation frame (len %d)", skb->len);
+ BT_ERR_RATELIMITED("Unexpected continuation frame (len %d)", skb->len);
l2cap_conn_unreliable(conn, ECOMM);
goto drop;
}
--
2.3.0
prev parent reply other threads:[~2015-02-24 6:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 6:25 [PATCH v2(sorta)] Unexpected-continuation-frame-printk flood avoidance Gregory M. Turner
2015-02-24 6:25 ` [PATCH v2(sorta) 1/2] bluetooth: Add BT_{INFO,ERR,DBG}_RATELIMITED Gregory M. Turner
2015-03-03 1:07 ` Marcel Holtmann
2015-03-14 19:01 ` Greg Turner
2015-03-19 18:54 ` [PATCH v3 1/1] bluetooth: l2cap_core: ratelimit continuation frame printk gmt
2015-02-24 6:25 ` Gregory M. Turner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424759141-17889-3-git-send-email-gmt@be-evil.net \
--to=gmt@be-evil.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.