All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Eyal Birger <eyal.birger@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	Shmulik Ladkani <shmulik.ladkani@gmail.com>,
	Eric Dumazet <edumazet@google.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/4] net: use skb->priority for overloading skb->dropcount and skb->reserved_tailroom instead of skb->mark
Date: Tue, 24 Feb 2015 06:41:08 -0800	[thread overview]
Message-ID: <1424788868.5565.81.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <CAHsH6GsqkA43Q-MMNOg+tVGSMjYMc9GUejOwV=VpkUQoaaGDBQ@mail.gmail.com>

On Tue, 2015-02-24 at 16:07 +0200, Eyal Birger wrote:

> Well, I took a look, then I tried :)
> 
> It breaks in packet_rcv() in a BUILD_BUG_ON() assertion. The asserted size is:
> 
> sizeof(*PACKET_SKB_CB(skb)) + MAX_ADDR_LEN - 8
> 
> This was introduced in ffbc61117d32dc4e768 ("[PACKET]: Fix skb->cb
> clobbering between aux and sockaddr")
> It requires the ability to store the maximal possible address length (32).

OK this might require to move origlen elsewhere in skb.

skb->dev for example is set to NULL, same for skb dst.

We have to be a bit creative/hacky to keep skb size small.

  parent reply	other threads:[~2015-02-24 14:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 17:52 [PATCH net-next v3 1/4] net: Rename sock_recv_ts_and_drops() to sock_cmsg_recv() Eyal Birger
2015-02-23 17:52 ` [PATCH net-next v3 2/4] ipv4,v6: avoid setting skb->priority when skb->reserved_tailroom is in use in igmpv3/mld Eyal Birger
2015-02-23 17:52 ` [PATCH net-next v3 3/4] net: use skb->priority for overloading skb->dropcount and skb->reserved_tailroom instead of skb->mark Eyal Birger
2015-02-23 18:56   ` Shmulik Ladkani
2015-02-23 19:10     ` Eric Dumazet
2015-02-23 19:25       ` Eyal Birger
2015-02-23 19:51         ` Eric Dumazet
2015-02-23 21:48     ` David Miller
2015-02-24  6:58       ` Eyal Birger
2015-02-24 10:10         ` Eyal Birger
2015-02-24 13:18           ` Eric Dumazet
2015-02-24 14:07             ` Eyal Birger
2015-02-24 14:25               ` Eric Dumazet
2015-02-24 14:41                 ` Eyal Birger
2015-02-24 14:41               ` Eric Dumazet [this message]
2015-02-24 15:24                 ` Eyal Birger
2015-02-25 20:49                   ` Willem de Bruijn
2015-02-25 21:15                     ` Eyal Birger
2015-02-25 14:10               ` Eyal Birger
2015-02-25 16:50                 ` Eric Dumazet
2015-02-23 17:52 ` [PATCH net-next v3 4/4] net: Introducing socket mark receive socket option Eyal Birger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424788868.5565.81.camel@edumazet-glaptop2.roam.corp.google.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eyal.birger@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shmulik.ladkani@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.