From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Vesely Subject: Re: [libdrm][PATCH 3/2] Fix always true comparison. Date: Wed, 25 Feb 2015 12:11:40 -0500 Message-ID: <1424884300.4113.11.camel@rutgers.edu> References: <1423517995-28251-1-git-send-email-jan.vesely@rutgers.edu> <1423527043-21264-1-git-send-email-jan.vesely@rutgers.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0061852807==" Return-path: Received: from mail-qc0-f180.google.com (mail-qc0-f180.google.com [209.85.216.180]) by gabe.freedesktop.org (Postfix) with ESMTP id 0067F6E6A6 for ; Wed, 25 Feb 2015 09:11:42 -0800 (PST) Received: by qcvs11 with SMTP id s11so3998668qcv.11 for ; Wed, 25 Feb 2015 09:11:42 -0800 (PST) In-Reply-To: <1423527043-21264-1-git-send-email-jan.vesely@rutgers.edu> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Emil Velikov List-Id: dri-devel@lists.freedesktop.org --===============0061852807== Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Y0utuXisuMph8wW+B8KU" --=-Y0utuXisuMph8wW+B8KU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable gentle ping On Mon, 2015-02-09 at 19:10 -0500, Jan Vesely wrote: > The only user I found is xserver, it can return -1 under certain conditio= ns. > So check for -1 explicitly. >=20 > Signed-off-by: Jan Vesely > --- >=20 > I could not find whether it's actually legal to return encoded negative v= alues > in get_perm. This is a quick fix to detect the one case that I found. >=20 > xf86drm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/xf86drm.c b/xf86drm.c > index fb673b5..8e54ac9 100644 > --- a/xf86drm.c > +++ b/xf86drm.c > @@ -335,7 +335,7 @@ static int drmOpenDevice(dev_t dev, int minor, int ty= pe) > drm_server_info->get_perms(&serv_group, &serv_mode); > devmode =3D serv_mode ? serv_mode : DRM_DEV_MODE; > devmode &=3D ~(S_IXUSR|S_IXGRP|S_IXOTH); > - group =3D (serv_group >=3D 0) ? serv_group : DRM_DEV_GID; > + group =3D (serv_group !=3D ~0U) ? serv_group : DRM_DEV_GID; > } > =20 > #if !defined(UDEV) --=20 Jan Vesely --=-Y0utuXisuMph8wW+B8KU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJU7gJMAAoJEDhUsXb6ZiH/QnQQAIFr8QRnglzYx2MWNQMFmBed NtWuf+bHX0oRo2Vg3UyHi6MeMQcbI7JGLVn5dBePsF4feexNGPX8pqVJzatKqvWV ZFY8RNpvbh+NKmx+vhLFii/IkcHQ2H0dtrjnOj3XquhzFl8T0PWVedMULzw9lU7y pkjWYDA4fu5f5f0F+i9V6zST/OWLpsDrL5qtsUho8/to0RAreO514/Hl7jyYPDf+ i/dt0I6TyvSfXO18f9qwLxldY2exgHnpj0RjnpVdyS7yCLb/sR3cl2AZUnbiVOsH 8gko9d8DZei7A1qvdzGNCSB3odG0ldS+MLt2cAkgpV+NJvTf1VdGg9Wx3JsaPDZ3 Zvkb5sJT8yD2HWj+noqhKPptuROcm+y7NYurWPg275GhHdk0UtPdl0cYTlr2mJ/X upbowQP+retd2rCxNSXAIJVUTSdJzQOpooLeDiH7vH3g8980eUTGFxdDrMeVG4uy NbdpVXLdBFdVP6RP8R8xULhjFkdcm6+143H6Kfm5hPck7jmlM9OVykFmx41Mqqca n5Xv3WWmQenjv47FrJTOvKdk5xgrRPHSDk30S2eSwN351aOqeNJ2e7oyoRx+C0eY CVnq6w3T7tdLY3AgoFRCRB4H2MPahNG8TTOJiqxYeCZTF93zETj7xdFJyz3nBxoz IefogWv3GyiM8uPYAIga =FnEs -----END PGP SIGNATURE----- --=-Y0utuXisuMph8wW+B8KU-- --===============0061852807== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0061852807==--