Re: [tip:perf/x86] perf/x86/intel: Add Intel Cache QoS Monitoring support

From: Matt Fleming <matt.fleming@intel.com>
To: <mingo@kernel.org>, <jolsa@redhat.com>,
	<torvalds@linux-foundation.org>, <peterz@infradead.org>,
	<linux-kernel@vger.kernel.org>, <acme@kernel.org>,
	<acme@redhat.com>, <hpa@zytor.com>, <kanaka.d.juvva@intel.com>,
	<vikas.shivappa@linux.intel.com>, <tglx@linutronix.de>
Cc: <linux-tip-commits@vger.kernel.org>
Subject: Re: [tip:perf/x86] perf/x86/intel: Add Intel Cache QoS Monitoring support
Date: Thu, 26 Feb 2015 18:47:00 +0000	[thread overview]
Message-ID: <1424976420.15321.35.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <tip-4afbb24ce5e723c8a093a6674a3c33062175078a@git.kernel.org>

On Wed, 2015-02-25 at 20:15 -0800, tip-bot for Matt Fleming wrote:
> Commit-ID:  4afbb24ce5e723c8a093a6674a3c33062175078a
> Gitweb:     http://git.kernel.org/tip/4afbb24ce5e723c8a093a6674a3c33062175078a
> Author:     Matt Fleming <matt.fleming@intel.com>
> AuthorDate: Fri, 23 Jan 2015 18:45:44 +0000
> Committer:  Ingo Molnar <mingo@kernel.org>
> CommitDate: Wed, 25 Feb 2015 13:53:32 +0100
> 
> perf/x86/intel: Add Intel Cache QoS Monitoring support
> 
> Future Intel Xeon processors support a Cache QoS Monitoring feature that
> allows tracking of the LLC occupancy for a task or task group, i.e. the
> amount of data in pulled into the LLC for the task (group).
> 
> Currently the PMU only supports per-cpu events. We create an event for
> each cpu and read out all the LLC occupancy values.
> 
> Because this results in duplicate values being written out to userspace,
> we also export a .per-pkg event file so that the perf tools only
> accumulate values for one cpu per package.
> 
> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Kanaka Juvva <kanaka.d.juvva@intel.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Vikas Shivappa <vikas.shivappa@linux.intel.com>
> Link: http://lkml.kernel.org/r/1422038748-21397-6-git-send-email-matt@codeblueprint.co.uk
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
>  arch/x86/kernel/cpu/perf_event_intel_cqm.c | 530 +++++++++++++++++++++++++++++
>  include/linux/perf_event.h                 |   7 +
>  2 files changed, 537 insertions(+)

Weird. I just noticed that the Makefile hunk got dropped. Was that
intentional?

diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
index 80091ae54c2b..6c1ca139f736 100644
--- a/arch/x86/kernel/cpu/Makefile
+++ b/arch/x86/kernel/cpu/Makefile
@@ -39,7 +39,7 @@ obj-$(CONFIG_CPU_SUP_AMD)             += perf_event_amd_iommu.o
 endif
 obj-$(CONFIG_CPU_SUP_INTEL)            += perf_event_p6.o perf_event_knc.o perf_event_p4.o
 obj-$(CONFIG_CPU_SUP_INTEL)            += perf_event_intel_lbr.o perf_event_intel_ds.o perf_event_intel.o
-obj-$(CONFIG_CPU_SUP_INTEL)            += perf_event_intel_rapl.o
+obj-$(CONFIG_CPU_SUP_INTEL)            += perf_event_intel_rapl.o perf_event_intel_cqm.o
 
 obj-$(CONFIG_PERF_EVENTS_INTEL_UNCORE) += perf_event_intel_uncore.o \
                                           perf_event_intel_uncore_snb.o \

