From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753814AbbCBKCu (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Mar 2015 05:02:50 -0500
Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:63518 "EHLO
	mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751462AbbCBKCq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Mar 2015 05:02:46 -0500
From: Lino Sanfilippo <lsanfil@marvell.com>
To: <linux@arm.linux.org.uk>, <linux-arm-kernel@lists.infradead.org>
CC: <linux-kernel@vger.kernel.org>, <LinoSanfilippo@gmx.de>,
        Lino Sanfilippo <lsanfil@marvell.com>
Subject: [RFC PATCH 0/1] Wrong structure alignment due to compiler attribute "section"
Date: Mon, 2 Mar 2015 11:01:41 +0100
Message-ID: <1425290502-2322-1-git-send-email-lsanfil@marvell.com>
X-Mailer: git-send-email 1.9.1
MIME-Version: 1.0
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000
 definitions=2015-03-02_01:2015-02-27,2015-03-01,1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=7.0.1-1402240000 definitions=main-1503020108
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi,

I came across a problem concerning structure alignment on ARM architectures (in
this case the "clock_provider" struct) when structures are placed by means of the
"section" compiler attribute. I noticed that with a certain cross compiler one
byte padding is inserted in between the structures:

<snip> System.map
c074cec0 T __clk_of_table
c074cec0 t __of_table_fixed_factor_clk
c074cec0 T __stop_kprobe_blacklist
c074cf88 t __of_table_fixed_clk
c074d050 t __of_table_gpio_gate_clk
c074d118 t __of_table_mv88f6180_clk
c074d1e0 t __of_table_kirkwood_clk
c074d2a8 t __clk_of_table_sentinel
<snap>

As one can see the difference between the adresses are 200 bytes although a
clock_provider only is 196 bytes in size. 

The problem is that in of_clk_init() the __clk_of_table is used as the base of
an array. Due to the padding the values in all array elements but the first one
are corruped. However with another cross compiler I could not trigger this. So
this issue seems to be compiler/linker dependent. With the attached patch
applied the layout is correct: 

c074ce58 T __clk_of_table
c074ce58 t __of_table_fixed_factor_clk
c074ce58 T __stop_kprobe_blacklist
c074cf1c t __of_table_fixed_clk
c074cfe0 t __of_table_gpio_gate_clk
c074d0a4 t __of_table_mv88f6180_clk
c074d168 t __of_table_kirkwood_clk
c074d22c t __clk_of_table_sentinel

I can trigger the issue with this compiler:
wget http://www.plugcomputer.org/405/us/gplugd/tool-chain/arm-marvell-linux-gnueabi.tar.bz2

Note that this issue popped up some years ago for x86 too:
http://lkml.iu.edu/hypermail/linux/kernel/0706.2/2552.html

I am not sure that this is the right fix though, thats why I sent that as an
RFC.

Regards, 
Lino


Lino Sanfilippo (1):
  ARM: Ensure correct structure alignment when using compiler attribute
    "section"

 include/linux/compiler.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.9.1


From mboxrd@z Thu Jan  1 00:00:00 1970
From: lsanfil@marvell.com (Lino Sanfilippo)
Date: Mon, 2 Mar 2015 11:01:41 +0100
Subject: [RFC PATCH 0/1] Wrong structure alignment due to compiler attribute
 "section"
Message-ID: <1425290502-2322-1-git-send-email-lsanfil@marvell.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org


Hi,

I came across a problem concerning structure alignment on ARM architectures (in
this case the "clock_provider" struct) when structures are placed by means of the
"section" compiler attribute. I noticed that with a certain cross compiler one
byte padding is inserted in between the structures:

<snip> System.map
c074cec0 T __clk_of_table
c074cec0 t __of_table_fixed_factor_clk
c074cec0 T __stop_kprobe_blacklist
c074cf88 t __of_table_fixed_clk
c074d050 t __of_table_gpio_gate_clk
c074d118 t __of_table_mv88f6180_clk
c074d1e0 t __of_table_kirkwood_clk
c074d2a8 t __clk_of_table_sentinel
<snap>

As one can see the difference between the adresses are 200 bytes although a
clock_provider only is 196 bytes in size. 

The problem is that in of_clk_init() the __clk_of_table is used as the base of
an array. Due to the padding the values in all array elements but the first one
are corruped. However with another cross compiler I could not trigger this. So
this issue seems to be compiler/linker dependent. With the attached patch
applied the layout is correct: 

c074ce58 T __clk_of_table
c074ce58 t __of_table_fixed_factor_clk
c074ce58 T __stop_kprobe_blacklist
c074cf1c t __of_table_fixed_clk
c074cfe0 t __of_table_gpio_gate_clk
c074d0a4 t __of_table_mv88f6180_clk
c074d168 t __of_table_kirkwood_clk
c074d22c t __clk_of_table_sentinel

I can trigger the issue with this compiler:
wget http://www.plugcomputer.org/405/us/gplugd/tool-chain/arm-marvell-linux-gnueabi.tar.bz2

Note that this issue popped up some years ago for x86 too:
http://lkml.iu.edu/hypermail/linux/kernel/0706.2/2552.html

I am not sure that this is the right fix though, thats why I sent that as an
RFC.

Regards, 
Lino


Lino Sanfilippo (1):
  ARM: Ensure correct structure alignment when using compiler attribute
    "section"

 include/linux/compiler.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
1.9.1