All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 4/4] block: Drop bdrv_find
Date: Mon,  2 Mar 2015 19:36:49 +0800	[thread overview]
Message-ID: <1425296209-1476-5-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1425296209-1476-1-git-send-email-famz@redhat.com>

All callers are converted, so drop it.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block.c               | 9 ---------
 include/block/block.h | 1 -
 2 files changed, 10 deletions(-)

diff --git a/block.c b/block.c
index 9b707e3..742f82c 100644
--- a/block.c
+++ b/block.c
@@ -3780,15 +3780,6 @@ void bdrv_iterate_format(void (*it)(void *opaque, const char *name),
     g_free(formats);
 }
 
-/* This function is to find block backend bs */
-/* TODO convert callers to blk_by_name(), then remove */
-BlockDriverState *bdrv_find(const char *name)
-{
-    BlockBackend *blk = blk_by_name(name);
-
-    return blk ? blk_bs(blk) : NULL;
-}
-
 /* This function is to find a node in the bs graph */
 BlockDriverState *bdrv_find_node(const char *node_name)
 {
diff --git a/include/block/block.h b/include/block/block.h
index 471d11d..2c121a5 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -370,7 +370,6 @@ int bdrv_media_changed(BlockDriverState *bs);
 void bdrv_lock_medium(BlockDriverState *bs, bool locked);
 void bdrv_eject(BlockDriverState *bs, bool eject_flag);
 const char *bdrv_get_format_name(BlockDriverState *bs);
-BlockDriverState *bdrv_find(const char *name);
 BlockDriverState *bdrv_find_node(const char *node_name);
 BlockDeviceInfoList *bdrv_named_nodes_list(void);
 BlockDriverState *bdrv_lookup_bs(const char *device,
-- 
1.9.3

  parent reply	other threads:[~2015-03-02 11:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02 11:36 [Qemu-devel] [PATCH 0/4] block: Convert bdrv_find to blk_by_name and drop it Fam Zheng
2015-03-02 11:36 ` [Qemu-devel] [PATCH 1/4] monitor: Convert bdrv_find to blk_by_name Fam Zheng
2015-03-02 15:30   ` Max Reitz
2015-03-02 11:36 ` [Qemu-devel] [PATCH 2/4] migration: " Fam Zheng
2015-03-02 15:32   ` Max Reitz
2015-03-02 11:36 ` [Qemu-devel] [PATCH 3/4] blockdev: " Fam Zheng
2015-03-02 15:48   ` Max Reitz
2015-03-02 11:36 ` Fam Zheng [this message]
2015-03-02 15:51   ` [Qemu-devel] [PATCH 4/4] block: Drop bdrv_find Max Reitz
2015-03-03 20:47 ` [Qemu-devel] [PATCH 0/4] block: Convert bdrv_find to blk_by_name and drop it Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425296209-1476-5-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.