From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758192AbbCDEQ6 (ORCPT ); Tue, 3 Mar 2015 23:16:58 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:60258 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499AbbCDEQ4 (ORCPT ); Tue, 3 Mar 2015 23:16:56 -0500 From: He Kuang To: CC: , , , Subject: [PATCH] perf hists browser: Fix segfault when all entries be filtered Date: Wed, 4 Mar 2015 12:13:36 +0800 Message-ID: <1425442416-29035-1-git-send-email-hekuang@huawei.com> X-Mailer: git-send-email 2.2.0.33.gc18b867 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.197.189] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When all perf report entries be filtered, the result of hists__filter_entries() can be NULL, check the result before processing. Miss this checking will cause segmentation fault like this: $ perf report (filter all entries and left nothing, then zoom in/out) perf: Segmentation fault -------- backtrace -------- ../bin/perf[0x4d1858] ../lib64/libc.so.6(+0x3545f)[0x7fe72fc1145f] ../bin/perf[0x4cd9f5] ../bin/perf[0x4ce176] ../bin/perf[0x4d0506] ../bin/perf[0x41a94f] ../bin/perf[0x408cf2] ../bin/perf[0x408455] ../lib64/libc.so.6(__libc_start_main+0xf4)[0x7fe72fbfdbd4] ../bin/perf[0x408584] Signed-off-by: He Kuang --- tools/perf/ui/browsers/hists.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 788506e..1106bb8 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c @@ -992,6 +992,9 @@ static void ui_browser__hists_seek(struct ui_browser *browser, * and stop when we printed enough lines to fill the screen. */ do_offset: + if (!nd) + return; + if (offset > 0) { do { h = rb_entry(nd, struct hist_entry, rb_node); -- 2.2.0.33.gc18b867