From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST 03/12] osstest migrate support check
 catch -> variables
Date: Wed, 11 Mar 2015 16:15:58 +0000
Message-ID: <1426090558.21353.305.camel@citrix.com>
References: <1423480206-9729-1-git-send-email-wei.liu2@citrix.com>
	<1423480206-9729-4-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423480206-9729-4-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: jfehlig@suse.com, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-02-09 at 11:09 +0000, Wei Liu wrote:
> From: Ian Jackson <Ian.Jackson@eu.citrix.com>

I remember the f2f discussion around this, but I cannot remember what
this is actually supposed to do. Can you? If so could you write it down
please ;-)

> 
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> ---
>  sg-run-job | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sg-run-job b/sg-run-job
> index 2cf810a..cc2ab3b 100755
> --- a/sg-run-job
> +++ b/sg-run-job
> @@ -289,7 +289,9 @@ proc run-job/test-pair {} {
>  }
>  
>  proc test-guest-migr {g} {
> -    if {[catch { run-ts . = ts-migrate-support-check + host $g }]} return
> +    set to_reap [spawn-ts . = ts-migrate-support-check + host $g]
> +    set can_migrate [reap-ts $to_reap]
> +    if {!$can_migrate} return
>  
>      foreach iteration {{} .2} {
>          run-ts . =$iteration ts-guest-saverestore + host $g