From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST 08/12] ts-libvirt-build: run libvirt
	test suite
Date: Wed, 11 Mar 2015 16:31:25 +0000
Message-ID: <1426091485.21353.314.camel@citrix.com>
References: <1423480206-9729-1-git-send-email-wei.liu2@citrix.com>
	<1423480206-9729-9-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423480206-9729-9-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: jfehlig@suse.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-02-09 at 11:10 +0000, Wei Liu wrote:
> We're interested in xlconfigtest. Since we're running test anyway run
> the whole suite.

This is run at build time? I take it doesn't (and will never) require an
active system?

> @@ -69,7 +61,10 @@ END
>  sub build() {
>      target_cmd_build($ho, 3600, $builddir, <<END);
>          cd libvirt
> -        (make $makeflags 2>&1 && touch ../build-ok-stamp) |tee ../log
> +        (make $makeflags 2>&1 && \\
> +         LD_LIBRARY_PATH=$xenprefix/lib/ \\
> +           make check VIR_TEST_EXPENSIVE=1 2>&1 && \\
> +         touch ../build-ok-stamp) |tee ../log

I think this would be preferable as a separate target_cmd_build
invocation to run the tests, to make it clearer in the logs what
happened.