From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST 12/12] make-flight, mfi-common: create live migration test for libvirt Date: Wed, 11 Mar 2015 16:38:59 +0000 Message-ID: <1426091939.21353.321.camel@citrix.com> References: <1423480206-9729-1-git-send-email-wei.liu2@citrix.com> <1423480206-9729-13-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423480206-9729-13-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: jfehlig@suse.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-02-09 at 11:10 +0000, Wei Liu wrote: > Signed-off-by: Wei Liu > Cc: Ian Campbell > Cc: Ian Jackson > --- > make-flight | 13 +++++++++++-- > mfi-common | 6 +++++- > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/make-flight b/make-flight > index 23d51ea..80c9c39 100755 > --- a/make-flight > +++ b/make-flight > @@ -419,11 +419,20 @@ test_matrix_do_one () { > done # qemuu_suffix > > # Test live migration > - job_create_test test-$xenarch$kern-$dom0arch-pair test-pair \ > - $pairtoolstack $xenarch $dom0arch \ > + for toolstack in $pairtoolstack; do > + # Don't change test case name for old test cases with xl and xend > + if [ x$toolstack = xxl -o x$toolstack = xxend ]; then > + toolstack_suffix="" > + else > + toolstack_suffix="-$toolstack" > + fi > + job_create_test test-$xenarch$kern-$dom0arch$toolstack_suffix-pair \ toolstack_suffix doesn't need {} around it, does it? I think not since "-" is not valid in a shell var, but wanted to check. Assuming I'm right that it doesn't: Acked-by: Ian Campbell