* [PATCH 0/15] don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: linux-arm-kernel
These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on
static functions.
This was done using the following semantic patch:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 0/15] don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: alsa-devel, linux-nfs, linux-scsi, linux-rdma, kernel-janitors,
linux-wireless, linux-kernel, linux-wpan, target-devel,
linux-crypto, netdev, linux-media, linuxppc-dev, linux-edac
These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on
static functions.
This was done using the following semantic patch:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 0/15] don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: linux-arm-kernel
Cc: alsa-devel, linux-nfs, linux-scsi, linux-rdma, kernel-janitors,
linux-wireless, linux-kernel, linux-wpan, target-devel,
linux-crypto, netdev, linux-media, linuxppc-dev, linux-edac
These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on
static functions.
This was done using the following semantic patch:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 1/15] NFSv4.1: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Trond Myklebust
Cc: kernel-janitors, Anna Schumaker, linux-nfs, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
fs/nfs/pnfs.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1902,7 +1902,6 @@ static void pnfs_writehdr_free(struct nf
pnfs_put_lseg(hdr->lseg);
nfs_pgio_header_free(hdr);
}
-EXPORT_SYMBOL_GPL(pnfs_writehdr_free);
int
pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
@@ -2032,7 +2031,6 @@ static void pnfs_readhdr_free(struct nfs
pnfs_put_lseg(hdr->lseg);
nfs_pgio_header_free(hdr);
}
-EXPORT_SYMBOL_GPL(pnfs_readhdr_free);
int
pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 1/15] NFSv4.1: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Trond Myklebust
Cc: kernel-janitors, Anna Schumaker, linux-nfs, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
fs/nfs/pnfs.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1902,7 +1902,6 @@ static void pnfs_writehdr_free(struct nf
pnfs_put_lseg(hdr->lseg);
nfs_pgio_header_free(hdr);
}
-EXPORT_SYMBOL_GPL(pnfs_writehdr_free);
int
pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
@@ -2032,7 +2031,6 @@ static void pnfs_readhdr_free(struct nfs
pnfs_put_lseg(hdr->lseg);
nfs_pgio_header_free(hdr);
}
-EXPORT_SYMBOL_GPL(pnfs_readhdr_free);
int
pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 1/15] NFSv4.1: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-12 15:59 ` Trond Myklebust
-1 siblings, 0 replies; 65+ messages in thread
From: Trond Myklebust @ 2015-03-12 15:59 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Anna Schumaker, linux-nfs, linux-kernel, daniel
On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> fs/nfs/pnfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff -u -p a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -1902,7 +1902,6 @@ static void pnfs_writehdr_free(struct nf
> pnfs_put_lseg(hdr->lseg);
> nfs_pgio_header_free(hdr);
> }
> -EXPORT_SYMBOL_GPL(pnfs_writehdr_free);
>
> int
> pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
> @@ -2032,7 +2031,6 @@ static void pnfs_readhdr_free(struct nfs
> pnfs_put_lseg(hdr->lseg);
> nfs_pgio_header_free(hdr);
> }
> -EXPORT_SYMBOL_GPL(pnfs_readhdr_free);
>
> int
> pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)
>
Thanks Julia! Applied....
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 1/15] NFSv4.1: don't export static symbol
@ 2015-03-12 15:59 ` Trond Myklebust
0 siblings, 0 replies; 65+ messages in thread
From: Trond Myklebust @ 2015-03-12 15:59 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, Anna Schumaker, linux-nfs, linux-kernel, daniel
On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> fs/nfs/pnfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff -u -p a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -1902,7 +1902,6 @@ static void pnfs_writehdr_free(struct nf
> pnfs_put_lseg(hdr->lseg);
> nfs_pgio_header_free(hdr);
> }
> -EXPORT_SYMBOL_GPL(pnfs_writehdr_free);
>
> int
> pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
> @@ -2032,7 +2031,6 @@ static void pnfs_readhdr_free(struct nfs
> pnfs_put_lseg(hdr->lseg);
> nfs_pgio_header_free(hdr);
> }
> -EXPORT_SYMBOL_GPL(pnfs_readhdr_free);
>
> int
> pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)
>
Thanks Julia! Applied....
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 2/15] powerpc: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
(?)
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: kernel-janitors, Paul Mackerras, Michael Ellerman, linuxppc-dev,
linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Furthermore, the function is never used, so its definition is dropped as
well.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/powerpc/sysdev/qe_lib/qe_io.c | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/arch/powerpc/sysdev/qe_lib/qe_io.c b/arch/powerpc/sysdev/qe_lib/qe_io.c
index d099941..7ea0174 100644
--- a/arch/powerpc/sysdev/qe_lib/qe_io.c
+++ b/arch/powerpc/sysdev/qe_lib/qe_io.c
@@ -190,28 +190,3 @@ int par_io_of_config(struct device_node *np)
return 0;
}
EXPORT_SYMBOL(par_io_of_config);
-
-#ifdef DEBUG
-static void dump_par_io(void)
-{
- unsigned int i;
-
- printk(KERN_INFO "%s: par_io=%p\n", __func__, par_io);
- for (i = 0; i < num_par_io_ports; i++) {
- printk(KERN_INFO " cpodr[%u]=%08x\n", i,
- in_be32(&par_io[i].cpodr));
- printk(KERN_INFO " cpdata[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdata));
- printk(KERN_INFO " cpdir1[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdir1));
- printk(KERN_INFO " cpdir2[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdir2));
- printk(KERN_INFO " cppar1[%u]=%08x\n", i,
- in_be32(&par_io[i].cppar1));
- printk(KERN_INFO " cppar2[%u]=%08x\n", i,
- in_be32(&par_io[i].cppar2));
- }
-
-}
-EXPORT_SYMBOL(dump_par_io);
-#endif /* DEBUG */
^ permalink raw reply related [flat|nested] 65+ messages in thread* [PATCH 2/15] powerpc: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: daniel, kernel-janitors, linux-kernel, Paul Mackerras, linuxppc-dev
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Furthermore, the function is never used, so its definition is dropped as
well.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/powerpc/sysdev/qe_lib/qe_io.c | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/arch/powerpc/sysdev/qe_lib/qe_io.c b/arch/powerpc/sysdev/qe_lib/qe_io.c
index d099941..7ea0174 100644
--- a/arch/powerpc/sysdev/qe_lib/qe_io.c
+++ b/arch/powerpc/sysdev/qe_lib/qe_io.c
@@ -190,28 +190,3 @@ int par_io_of_config(struct device_node *np)
return 0;
}
EXPORT_SYMBOL(par_io_of_config);
-
-#ifdef DEBUG
-static void dump_par_io(void)
-{
- unsigned int i;
-
- printk(KERN_INFO "%s: par_io=%p\n", __func__, par_io);
- for (i = 0; i < num_par_io_ports; i++) {
- printk(KERN_INFO " cpodr[%u]=%08x\n", i,
- in_be32(&par_io[i].cpodr));
- printk(KERN_INFO " cpdata[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdata));
- printk(KERN_INFO " cpdir1[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdir1));
- printk(KERN_INFO " cpdir2[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdir2));
- printk(KERN_INFO " cppar1[%u]=%08x\n", i,
- in_be32(&par_io[i].cppar1));
- printk(KERN_INFO " cppar2[%u]=%08x\n", i,
- in_be32(&par_io[i].cppar2));
- }
-
-}
-EXPORT_SYMBOL(dump_par_io);
-#endif /* DEBUG */
^ permalink raw reply related [flat|nested] 65+ messages in thread* [PATCH 2/15] powerpc: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: daniel, kernel-janitors, linux-kernel, Paul Mackerras, linuxppc-dev
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Furthermore, the function is never used, so its definition is dropped as
well.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/powerpc/sysdev/qe_lib/qe_io.c | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/arch/powerpc/sysdev/qe_lib/qe_io.c b/arch/powerpc/sysdev/qe_lib/qe_io.c
index d099941..7ea0174 100644
--- a/arch/powerpc/sysdev/qe_lib/qe_io.c
+++ b/arch/powerpc/sysdev/qe_lib/qe_io.c
@@ -190,28 +190,3 @@ int par_io_of_config(struct device_node *np)
return 0;
}
EXPORT_SYMBOL(par_io_of_config);
-
-#ifdef DEBUG
-static void dump_par_io(void)
-{
- unsigned int i;
-
- printk(KERN_INFO "%s: par_io=%p\n", __func__, par_io);
- for (i = 0; i < num_par_io_ports; i++) {
- printk(KERN_INFO " cpodr[%u]=%08x\n", i,
- in_be32(&par_io[i].cpodr));
- printk(KERN_INFO " cpdata[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdata));
- printk(KERN_INFO " cpdir1[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdir1));
- printk(KERN_INFO " cpdir2[%u]=%08x\n", i,
- in_be32(&par_io[i].cpdir2));
- printk(KERN_INFO " cppar1[%u]=%08x\n", i,
- in_be32(&par_io[i].cppar1));
- printk(KERN_INFO " cppar2[%u]=%08x\n", i,
- in_be32(&par_io[i].cppar2));
- }
-
-}
-EXPORT_SYMBOL(dump_par_io);
-#endif /* DEBUG */
^ permalink raw reply related [flat|nested] 65+ messages in thread
* [PATCH 3/15] net/mlx5_core: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Eli Cohen; +Cc: kernel-janitors, netdev, linux-rdma, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -697,7 +697,6 @@ err_dbg:
debugfs_remove(priv->dbg_root);
return err;
}
-EXPORT_SYMBOL(mlx5_dev_init);
static void mlx5_dev_cleanup(struct mlx5_core_dev *dev)
{
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 3/15] net/mlx5_core: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Eli Cohen; +Cc: kernel-janitors, netdev, linux-rdma, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -697,7 +697,6 @@ err_dbg:
debugfs_remove(priv->dbg_root);
return err;
}
-EXPORT_SYMBOL(mlx5_dev_init);
static void mlx5_dev_cleanup(struct mlx5_core_dev *dev)
{
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 3/15] net/mlx5_core: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-12 4:04 ` David Miller
-1 siblings, 0 replies; 65+ messages in thread
From: David Miller @ 2015-03-12 4:04 UTC (permalink / raw)
To: Julia.Lawall
Cc: eli, kernel-janitors, netdev, linux-rdma, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Wed, 11 Mar 2015 17:56:25 +0100
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
...
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thank you Julia.
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 4/15] crypto: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Herbert Xu
Cc: kernel-janitors, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, linux-crypto, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/x86/crypto/glue_helper.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/arch/x86/crypto/glue_helper.c b/arch/x86/crypto/glue_helper.c
--- a/arch/x86/crypto/glue_helper.c
+++ b/arch/x86/crypto/glue_helper.c
@@ -232,7 +232,6 @@ static void glue_ctr_crypt_final_128bit(
le128_to_be128((be128 *)walk->iv, &ctrblk);
}
-EXPORT_SYMBOL_GPL(glue_ctr_crypt_final_128bit);
static unsigned int __glue_ctr_crypt_128bit(const struct common_glue_ctx *gctx,
struct blkcipher_desc *desc,
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 4/15] crypto: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Herbert Xu
Cc: kernel-janitors, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, linux-crypto, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/x86/crypto/glue_helper.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/arch/x86/crypto/glue_helper.c b/arch/x86/crypto/glue_helper.c
--- a/arch/x86/crypto/glue_helper.c
+++ b/arch/x86/crypto/glue_helper.c
@@ -232,7 +232,6 @@ static void glue_ctr_crypt_final_128bit(
le128_to_be128((be128 *)walk->iv, &ctrblk);
}
-EXPORT_SYMBOL_GPL(glue_ctr_crypt_final_128bit);
static unsigned int __glue_ctr_crypt_128bit(const struct common_glue_ctx *gctx,
struct blkcipher_desc *desc,
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 4/15] crypto: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-13 10:38 ` Herbert Xu
-1 siblings, 0 replies; 65+ messages in thread
From: Herbert Xu @ 2015-03-13 10:38 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, linux-crypto, linux-kernel, daniel
On Wed, Mar 11, 2015 at 05:56:26PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 4/15] crypto: don't export static symbol
@ 2015-03-13 10:38 ` Herbert Xu
0 siblings, 0 replies; 65+ messages in thread
From: Herbert Xu @ 2015-03-13 10:38 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, David S. Miller, Thomas Gleixner, Ingo Molnar,
H. Peter Anvin, x86, linux-crypto, linux-kernel, daniel
On Wed, Mar 11, 2015 at 05:56:26PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 5/15] clockevents: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: kernel-janitors, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
kernel/time/clockevents.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/kernel/time/clockevents.c b/kernel/time/clockevents.c
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -424,7 +424,6 @@ int clockevents_unbind_device(struct clo
mutex_unlock(&clockevents_mutex);
return ret;
}
-EXPORT_SYMBOL_GPL(clockevents_unbind);
/* Sanity check of mode transition callbacks */
static int clockevents_sanity_check(struct clock_event_device *dev)
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 5/15] clockevents: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: kernel-janitors, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
kernel/time/clockevents.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/kernel/time/clockevents.c b/kernel/time/clockevents.c
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -424,7 +424,6 @@ int clockevents_unbind_device(struct clo
mutex_unlock(&clockevents_mutex);
return ret;
}
-EXPORT_SYMBOL_GPL(clockevents_unbind);
/* Sanity check of mode transition callbacks */
static int clockevents_sanity_check(struct clock_event_device *dev)
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 6/15] torture: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: linux-kernel, daniel; +Cc: kernel-janitors
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
kernel/torture.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/kernel/torture.c b/kernel/torture.c
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -206,7 +206,6 @@ static void torture_onoff_cleanup(void)
onoff_task = NULL;
#endif /* #ifdef CONFIG_HOTPLUG_CPU */
}
-EXPORT_SYMBOL_GPL(torture_onoff_cleanup);
/*
* Print online/offline testing statistics.
@@ -392,7 +391,6 @@ static void torture_shuffle_cleanup(void
}
shuffler_task = NULL;
}
-EXPORT_SYMBOL_GPL(torture_shuffle_cleanup);
/*
* Variables for auto-shutdown. This allows "lights out" torture runs
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 6/15] torture: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: linux-kernel, daniel; +Cc: kernel-janitors
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
kernel/torture.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/kernel/torture.c b/kernel/torture.c
--- a/kernel/torture.c
+++ b/kernel/torture.c
@@ -206,7 +206,6 @@ static void torture_onoff_cleanup(void)
onoff_task = NULL;
#endif /* #ifdef CONFIG_HOTPLUG_CPU */
}
-EXPORT_SYMBOL_GPL(torture_onoff_cleanup);
/*
* Print online/offline testing statistics.
@@ -392,7 +391,6 @@ static void torture_shuffle_cleanup(void
}
shuffler_task = NULL;
}
-EXPORT_SYMBOL_GPL(torture_shuffle_cleanup);
/*
* Variables for auto-shutdown. This allows "lights out" torture runs
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 7/15] media: pci: cx23885: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: kernel-janitors, linux-media, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/media/pci/cx23885/altera-ci.c | 3 ---
1 file changed, 3 deletions(-)
diff -u -p a/drivers/media/pci/cx23885/altera-ci.c b/drivers/media/pci/cx23885/altera-ci.c
--- a/drivers/media/pci/cx23885/altera-ci.c
+++ b/drivers/media/pci/cx23885/altera-ci.c
@@ -483,7 +483,6 @@ static void altera_hw_filt_release(void
}
}
-EXPORT_SYMBOL(altera_hw_filt_release);
void altera_ci_release(void *dev, int ci_nr)
{
@@ -598,7 +597,6 @@ static int altera_pid_feed_control(void
return 0;
}
-EXPORT_SYMBOL(altera_pid_feed_control);
static int altera_ci_start_feed(struct dvb_demux_feed *feed, int num)
{
@@ -699,7 +697,6 @@ err:
return ret;
}
-EXPORT_SYMBOL(altera_hw_filt_init);
int altera_ci_init(struct altera_ci_config *config, int ci_nr)
{
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 7/15] media: pci: cx23885: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: kernel-janitors, linux-media, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/media/pci/cx23885/altera-ci.c | 3 ---
1 file changed, 3 deletions(-)
diff -u -p a/drivers/media/pci/cx23885/altera-ci.c b/drivers/media/pci/cx23885/altera-ci.c
--- a/drivers/media/pci/cx23885/altera-ci.c
+++ b/drivers/media/pci/cx23885/altera-ci.c
@@ -483,7 +483,6 @@ static void altera_hw_filt_release(void
}
}
-EXPORT_SYMBOL(altera_hw_filt_release);
void altera_ci_release(void *dev, int ci_nr)
{
@@ -598,7 +597,6 @@ static int altera_pid_feed_control(void
return 0;
}
-EXPORT_SYMBOL(altera_pid_feed_control);
static int altera_ci_start_feed(struct dvb_demux_feed *feed, int num)
{
@@ -699,7 +697,6 @@ err:
return ret;
}
-EXPORT_SYMBOL(altera_hw_filt_init);
int altera_ci_init(struct altera_ci_config *config, int ci_nr)
{
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 8/15] libertas_tf: if_usb.c: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Kalle Valo; +Cc: kernel-janitors, linux-wireless, netdev, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/wireless/libertas_tf/if_usb.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/drivers/net/wireless/libertas_tf/if_usb.c b/drivers/net/wireless/libertas_tf/if_usb.c
--- a/drivers/net/wireless/libertas_tf/if_usb.c
+++ b/drivers/net/wireless/libertas_tf/if_usb.c
@@ -365,7 +365,6 @@ static int if_usb_reset_device(struct if
return ret;
}
-EXPORT_SYMBOL_GPL(if_usb_reset_device);
/**
* usb_tx_block - transfer data to the device
@@ -907,7 +906,6 @@ restart:
lbtf_deb_leave_args(LBTF_DEB_USB, "ret %d", ret);
return ret;
}
-EXPORT_SYMBOL_GPL(if_usb_prog_firmware);
#define if_usb_suspend NULL
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 8/15] libertas_tf: if_usb.c: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Kalle Valo; +Cc: kernel-janitors, linux-wireless, netdev, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/net/wireless/libertas_tf/if_usb.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/drivers/net/wireless/libertas_tf/if_usb.c b/drivers/net/wireless/libertas_tf/if_usb.c
--- a/drivers/net/wireless/libertas_tf/if_usb.c
+++ b/drivers/net/wireless/libertas_tf/if_usb.c
@@ -365,7 +365,6 @@ static int if_usb_reset_device(struct if
return ret;
}
-EXPORT_SYMBOL_GPL(if_usb_reset_device);
/**
* usb_tx_block - transfer data to the device
@@ -907,7 +906,6 @@ restart:
lbtf_deb_leave_args(LBTF_DEB_USB, "ret %d", ret);
return ret;
}
-EXPORT_SYMBOL_GPL(if_usb_prog_firmware);
#define if_usb_suspend NULL
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [8/15] libertas_tf: if_usb.c: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-13 14:18 ` Kalle Valo
-1 siblings, 0 replies; 65+ messages in thread
From: Kalle Valo @ 2015-03-13 14:18 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, linux-wireless, netdev, linux-kernel, daniel
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [8/15] libertas_tf: if_usb.c: don't export static symbol
@ 2015-03-13 14:18 ` Kalle Valo
0 siblings, 0 replies; 65+ messages in thread
From: Kalle Valo @ 2015-03-13 14:18 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, linux-wireless, netdev, linux-kernel, daniel
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 9/15] clk: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Mike Turquette; +Cc: kernel-janitors, Stephen Boyd, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/clk/clk.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/clk/clk.c b/drivers/clk/clk.c
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1350,7 +1350,6 @@ static unsigned long clk_core_get_rate(s
return rate;
}
-EXPORT_SYMBOL_GPL(clk_core_get_rate);
/**
* clk_get_rate - return the rate of clk
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 9/15] clk: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Mike Turquette; +Cc: kernel-janitors, Stephen Boyd, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/clk/clk.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/clk/clk.c b/drivers/clk/clk.c
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1350,7 +1350,6 @@ static unsigned long clk_core_get_rate(s
return rate;
}
-EXPORT_SYMBOL_GPL(clk_core_get_rate);
/**
* clk_get_rate - return the rate of clk
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 9/15] clk: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-12 6:03 ` Stephen Boyd
-1 siblings, 0 replies; 65+ messages in thread
From: Stephen Boyd @ 2015-03-12 6:03 UTC (permalink / raw)
To: Julia Lawall; +Cc: Mike Turquette, kernel-janitors, linux-kernel, daniel
On 03/11, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied to clk-fixes.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 9/15] clk: don't export static symbol
@ 2015-03-12 6:03 ` Stephen Boyd
0 siblings, 0 replies; 65+ messages in thread
From: Stephen Boyd @ 2015-03-12 6:03 UTC (permalink / raw)
To: Julia Lawall; +Cc: Mike Turquette, kernel-janitors, linux-kernel, daniel
On 03/11, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied to clk-fixes.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 10/15] scsi: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: James E.J. Bottomley; +Cc: kernel-janitors, linux-scsi, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/scsi/libsas/sas_scsi_host.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -440,7 +440,6 @@ static void sas_wait_eh(struct domain_de
goto retry;
}
}
-EXPORT_SYMBOL(sas_wait_eh);
static int sas_queue_reset(struct domain_device *dev, int reset_type,
u64 lun, int wait)
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 10/15] scsi: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: James E.J. Bottomley; +Cc: kernel-janitors, linux-scsi, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/scsi/libsas/sas_scsi_host.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
--- a/drivers/scsi/libsas/sas_scsi_host.c
+++ b/drivers/scsi/libsas/sas_scsi_host.c
@@ -440,7 +440,6 @@ static void sas_wait_eh(struct domain_de
goto retry;
}
}
-EXPORT_SYMBOL(sas_wait_eh);
static int sas_queue_reset(struct domain_device *dev, int reset_type,
u64 lun, int wait)
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 11/15] ASoC: ab8500-codec: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
(?)
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Liam Girdwood
Cc: kernel-janitors, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/soc/codecs/ab8500-codec.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2003,7 +2003,6 @@ static int ab8500_audio_setup_mics(struc
return 0;
}
-EXPORT_SYMBOL_GPL(ab8500_audio_setup_mics);
static int ab8500_audio_set_ear_cmv(struct snd_soc_codec *codec,
enum ear_cm_voltage ear_cmv)
@@ -2036,7 +2035,6 @@ static int ab8500_audio_set_ear_cmv(stru
return 0;
}
-EXPORT_SYMBOL_GPL(ab8500_audio_set_ear_cmv);
static int ab8500_audio_set_bit_delay(struct snd_soc_dai *dai,
unsigned int delay)
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 11/15] ASoC: ab8500-codec: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel, daniel, Takashi Iwai, kernel-janitors, linux-kernel,
Mark Brown
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/soc/codecs/ab8500-codec.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2003,7 +2003,6 @@ static int ab8500_audio_setup_mics(struc
return 0;
}
-EXPORT_SYMBOL_GPL(ab8500_audio_setup_mics);
static int ab8500_audio_set_ear_cmv(struct snd_soc_codec *codec,
enum ear_cm_voltage ear_cmv)
@@ -2036,7 +2035,6 @@ static int ab8500_audio_set_ear_cmv(stru
return 0;
}
-EXPORT_SYMBOL_GPL(ab8500_audio_set_ear_cmv);
static int ab8500_audio_set_bit_delay(struct snd_soc_dai *dai,
unsigned int delay)
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 11/15] ASoC: ab8500-codec: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel, daniel, Takashi Iwai, kernel-janitors, linux-kernel,
Mark Brown
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/soc/codecs/ab8500-codec.c | 2 --
1 file changed, 2 deletions(-)
diff -u -p a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-codec.c
--- a/sound/soc/codecs/ab8500-codec.c
+++ b/sound/soc/codecs/ab8500-codec.c
@@ -2003,7 +2003,6 @@ static int ab8500_audio_setup_mics(struc
return 0;
}
-EXPORT_SYMBOL_GPL(ab8500_audio_setup_mics);
static int ab8500_audio_set_ear_cmv(struct snd_soc_codec *codec,
enum ear_cm_voltage ear_cmv)
@@ -2036,7 +2035,6 @@ static int ab8500_audio_set_ear_cmv(stru
return 0;
}
-EXPORT_SYMBOL_GPL(ab8500_audio_set_ear_cmv);
static int ab8500_audio_set_bit_delay(struct snd_soc_dai *dai,
unsigned int delay)
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 11/15] ASoC: ab8500-codec: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
(?)
(?)
@ 2015-03-11 18:29 ` Mark Brown
-1 siblings, 0 replies; 65+ messages in thread
From: Mark Brown @ 2015-03-11 18:29 UTC (permalink / raw)
To: Julia Lawall
Cc: Liam Girdwood, kernel-janitors, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel, daniel
[-- Attachment #1: Type: text/plain, Size: 225 bytes --]
On Wed, Mar 11, 2015 at 05:56:33PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 12/15] i82443bxgx_edac: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Tim Small
Cc: kernel-janitors, Doug Thompson, Borislav Petkov,
Mauro Carvalho Chehab, linux-edac, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/edac/i82443bxgx_edac.c | 4 ----
1 file changed, 4 deletions(-)
diff -u -p a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
--- a/drivers/edac/i82443bxgx_edac.c
+++ b/drivers/edac/i82443bxgx_edac.c
@@ -350,8 +350,6 @@ fail:
return -ENODEV;
}
-EXPORT_SYMBOL_GPL(i82443bxgx_edacmc_probe1);
-
/* returns count (>= 0), or negative on error */
static int i82443bxgx_edacmc_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
@@ -384,8 +382,6 @@ static void i82443bxgx_edacmc_remove_one
edac_mc_free(mci);
}
-EXPORT_SYMBOL_GPL(i82443bxgx_edacmc_remove_one);
-
static const struct pci_device_id i82443bxgx_pci_tbl[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82443BX_0)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82443BX_2)},
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 12/15] i82443bxgx_edac: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Tim Small
Cc: kernel-janitors, Doug Thompson, Borislav Petkov,
Mauro Carvalho Chehab, linux-edac, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@
-EXPORT_SYMBOL_GPL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/edac/i82443bxgx_edac.c | 4 ----
1 file changed, 4 deletions(-)
diff -u -p a/drivers/edac/i82443bxgx_edac.c b/drivers/edac/i82443bxgx_edac.c
--- a/drivers/edac/i82443bxgx_edac.c
+++ b/drivers/edac/i82443bxgx_edac.c
@@ -350,8 +350,6 @@ fail:
return -ENODEV;
}
-EXPORT_SYMBOL_GPL(i82443bxgx_edacmc_probe1);
-
/* returns count (>= 0), or negative on error */
static int i82443bxgx_edacmc_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
@@ -384,8 +382,6 @@ static void i82443bxgx_edacmc_remove_one
edac_mc_free(mci);
}
-EXPORT_SYMBOL_GPL(i82443bxgx_edacmc_remove_one);
-
static const struct pci_device_id i82443bxgx_pci_tbl[] = {
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82443BX_0)},
{PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82443BX_2)},
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 12/15] i82443bxgx_edac: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 19:48 ` Borislav Petkov
-1 siblings, 0 replies; 65+ messages in thread
From: Borislav Petkov @ 2015-03-11 19:48 UTC (permalink / raw)
To: Julia Lawall
Cc: Tim Small, kernel-janitors, Doug Thompson, Mauro Carvalho Chehab,
linux-edac, linux-kernel
On Wed, Mar 11, 2015 at 05:56:34PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thanks.
Btw, from looking at this driver, it has been marked BROKEN since 2007
and we might just as well remove it. I'd be surprised if someone even
notices...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 12/15] i82443bxgx_edac: don't export static symbol
@ 2015-03-11 19:48 ` Borislav Petkov
0 siblings, 0 replies; 65+ messages in thread
From: Borislav Petkov @ 2015-03-11 19:48 UTC (permalink / raw)
To: Julia Lawall
Cc: Tim Small, kernel-janitors, Doug Thompson, Mauro Carvalho Chehab,
linux-edac, linux-kernel
On Wed, Mar 11, 2015 at 05:56:34PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied, thanks.
Btw, from looking at this driver, it has been marked BROKEN since 2007
and we might just as well remove it. I'd be surprised if someone even
notices...
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 13/15] ieee802154: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Alexander Aring
Cc: kernel-janitors, David S. Miller, linux-wpan, netdev,
linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
net/ieee802154/nl-mac.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/net/ieee802154/nl-mac.c b/net/ieee802154/nl-mac.c
--- a/net/ieee802154/nl-mac.c
+++ b/net/ieee802154/nl-mac.c
@@ -76,7 +76,6 @@ nla_put_failure:
nlmsg_free(msg);
return -ENOBUFS;
}
-EXPORT_SYMBOL(ieee802154_nl_start_confirm);
static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid,
u32 seq, int flags, struct net_device *dev)
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 13/15] ieee802154: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Alexander Aring
Cc: kernel-janitors, David S. Miller, linux-wpan, netdev,
linux-kernel, daniel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
net/ieee802154/nl-mac.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/net/ieee802154/nl-mac.c b/net/ieee802154/nl-mac.c
--- a/net/ieee802154/nl-mac.c
+++ b/net/ieee802154/nl-mac.c
@@ -76,7 +76,6 @@ nla_put_failure:
nlmsg_free(msg);
return -ENOBUFS;
}
-EXPORT_SYMBOL(ieee802154_nl_start_confirm);
static int ieee802154_nl_fill_iface(struct sk_buff *msg, u32 portid,
u32 seq, int flags, struct net_device *dev)
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 13/15] ieee802154: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 18:17 ` Alexander Aring
-1 siblings, 0 replies; 65+ messages in thread
From: Alexander Aring @ 2015-03-11 18:17 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, David S. Miller, linux-wpan, netdev,
linux-kernel, daniel, marcel
On Wed, Mar 11, 2015 at 05:56:35PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Marcel can you please queue this into bluetooth-next, or even bluetooth?
Thanks.
- Alex
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 13/15] ieee802154: don't export static symbol
@ 2015-03-11 18:17 ` Alexander Aring
0 siblings, 0 replies; 65+ messages in thread
From: Alexander Aring @ 2015-03-11 18:17 UTC (permalink / raw)
To: Julia Lawall
Cc: kernel-janitors, David S. Miller, linux-wpan, netdev,
linux-kernel, daniel, marcel
On Wed, Mar 11, 2015 at 05:56:35PM +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Alexander Aring <alex.aring@gmail.com>
Marcel can you please queue this into bluetooth-next, or even bluetooth?
Thanks.
- Alex
^ permalink raw reply [flat|nested] 65+ messages in thread
* Re: [PATCH 13/15] ieee802154: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-14 16:13 ` Marcel Holtmann
-1 siblings, 0 replies; 65+ messages in thread
From: Marcel Holtmann @ 2015-03-14 16:13 UTC (permalink / raw)
To: Julia Lawall
Cc: Alexander Aring, kernel-janitors, David S. Miller, linux-wpan,
netdev, Linux Kernel Mailing List, daniel
Hi Julia,
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> net/ieee802154/nl-mac.c | 1 -
> 1 file changed, 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 13/15] ieee802154: don't export static symbol
@ 2015-03-14 16:13 ` Marcel Holtmann
0 siblings, 0 replies; 65+ messages in thread
From: Marcel Holtmann @ 2015-03-14 16:13 UTC (permalink / raw)
To: Julia Lawall
Cc: Alexander Aring, kernel-janitors, David S. Miller, linux-wpan,
netdev, Linux Kernel Mailing List, daniel
Hi Julia,
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> net/ieee802154/nl-mac.c | 1 -
> 1 file changed, 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
(?)
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Krzysztof Halasa
Cc: kernel-janitors, Russell King, linux-arm-kernel, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/arm/mach-cns3xxx/pm.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/arch/arm/mach-cns3xxx/pm.c b/arch/arm/mach-cns3xxx/pm.c
--- a/arch/arm/mach-cns3xxx/pm.c
+++ b/arch/arm/mach-cns3xxx/pm.c
@@ -73,7 +73,6 @@ static void cns3xxx_pwr_soft_rst_force(u
__raw_writel(reg, PM_SOFT_RST_REG);
}
-EXPORT_SYMBOL(cns3xxx_pwr_soft_rst_force);
void cns3xxx_pwr_soft_rst(unsigned int block)
{
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: linux-arm-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/arm/mach-cns3xxx/pm.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/arch/arm/mach-cns3xxx/pm.c b/arch/arm/mach-cns3xxx/pm.c
--- a/arch/arm/mach-cns3xxx/pm.c
+++ b/arch/arm/mach-cns3xxx/pm.c
@@ -73,7 +73,6 @@ static void cns3xxx_pwr_soft_rst_force(u
__raw_writel(reg, PM_SOFT_RST_REG);
}
-EXPORT_SYMBOL(cns3xxx_pwr_soft_rst_force);
void cns3xxx_pwr_soft_rst(unsigned int block)
{
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: linux-arm-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
arch/arm/mach-cns3xxx/pm.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/arch/arm/mach-cns3xxx/pm.c b/arch/arm/mach-cns3xxx/pm.c
--- a/arch/arm/mach-cns3xxx/pm.c
+++ b/arch/arm/mach-cns3xxx/pm.c
@@ -73,7 +73,6 @@ static void cns3xxx_pwr_soft_rst_force(u
__raw_writel(reg, PM_SOFT_RST_REG);
}
-EXPORT_SYMBOL(cns3xxx_pwr_soft_rst_force);
void cns3xxx_pwr_soft_rst(unsigned int block)
{
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
(?)
@ 2015-03-11 21:09 ` Arnd Bergmann
-1 siblings, 0 replies; 65+ messages in thread
From: Arnd Bergmann @ 2015-03-11 21:09 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Julia Lawall, Krzysztof Halasa, Russell King, kernel-janitors,
linux-kernel
On Wednesday 11 March 2015 17:56:36 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Looks good. Krzysztof, do you want to pick this up and send me a
pull request together with other patches, or should I apply this
to the arm-soc fixes directly?
Arnd
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
@ 2015-03-11 21:09 ` Arnd Bergmann
0 siblings, 0 replies; 65+ messages in thread
From: Arnd Bergmann @ 2015-03-11 21:09 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 11 March 2015 17:56:36 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Looks good. Krzysztof, do you want to pick this up and send me a
pull request together with other patches, or should I apply this
to the arm-soc fixes directly?
Arnd
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
@ 2015-03-11 21:09 ` Arnd Bergmann
0 siblings, 0 replies; 65+ messages in thread
From: Arnd Bergmann @ 2015-03-11 21:09 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 11 March 2015 17:56:36 Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
Looks good. Krzysztof, do you want to pick this up and send me a
pull request together with other patches, or should I apply this
to the arm-soc fixes directly?
Arnd
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
2015-03-11 21:09 ` Arnd Bergmann
(?)
@ 2015-03-13 5:59 ` Krzysztof Hałasa
-1 siblings, 0 replies; 65+ messages in thread
From: Krzysztof Hałasa @ 2015-03-13 5:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, Julia Lawall, Russell King, kernel-janitors,
linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> Looks good. Krzysztof, do you want to pick this up and send me a
> pull request together with other patches, or should I apply this
> to the arm-soc fixes directly?
The latter, please.
Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
@ 2015-03-13 5:59 ` Krzysztof Hałasa
0 siblings, 0 replies; 65+ messages in thread
From: Krzysztof Hałasa @ 2015-03-13 5:59 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> Looks good. Krzysztof, do you want to pick this up and send me a
> pull request together with other patches, or should I apply this
> to the arm-soc fixes directly?
The latter, please.
Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
^ permalink raw reply [flat|nested] 65+ messages in thread
* Re: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
@ 2015-03-13 5:59 ` Krzysztof Hałasa
0 siblings, 0 replies; 65+ messages in thread
From: Krzysztof Hałasa @ 2015-03-13 5:59 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> Looks good. Krzysztof, do you want to pick this up and send me a
> pull request together with other patches, or should I apply this
> to the arm-soc fixes directly?
The latter, please.
Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
--
Krzysztof Halasa
Research Institute for Automation and Measurements PIAP
Al. Jerozolimskie 202, 02-486 Warsaw, Poland
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 65+ messages in thread
* Re: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
2015-03-13 5:59 ` Krzysztof Hałasa
(?)
@ 2015-03-13 10:04 ` Arnd Bergmann
-1 siblings, 0 replies; 65+ messages in thread
From: Arnd Bergmann @ 2015-03-13 10:04 UTC (permalink / raw)
To: Krzysztof Hałasa
Cc: linux-arm-kernel, Julia Lawall, Russell King, kernel-janitors,
linux-kernel
On Friday 13 March 2015 06:59:38 Krzysztof Hałasa wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > Looks good. Krzysztof, do you want to pick this up and send me a
> > pull request together with other patches, or should I apply this
> > to the arm-soc fixes directly?
>
> The latter, please.
> Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
> --
Applied to next/fixes-non-critical with your Ack, thanks!
Arnd
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 14/15] ARM: cns3xxx: don't export static symbol
@ 2015-03-13 10:04 ` Arnd Bergmann
0 siblings, 0 replies; 65+ messages in thread
From: Arnd Bergmann @ 2015-03-13 10:04 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 13 March 2015 06:59:38 Krzysztof Ha?asa wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > Looks good. Krzysztof, do you want to pick this up and send me a
> > pull request together with other patches, or should I apply this
> > to the arm-soc fixes directly?
>
> The latter, please.
> Acked-by: Krzysztof Ha?asa <khalasa@piap.pl>
> --
Applied to next/fixes-non-critical with your Ack, thanks!
Arnd
^ permalink raw reply [flat|nested] 65+ messages in thread
* Re: [PATCH 14/15] ARM: cns3xxx: don't export static symbol
@ 2015-03-13 10:04 ` Arnd Bergmann
0 siblings, 0 replies; 65+ messages in thread
From: Arnd Bergmann @ 2015-03-13 10:04 UTC (permalink / raw)
To: linux-arm-kernel
On Friday 13 March 2015 06:59:38 Krzysztof Hałasa wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > Looks good. Krzysztof, do you want to pick this up and send me a
> > pull request together with other patches, or should I apply this
> > to the arm-soc fixes directly?
>
> The latter, please.
> Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
> --
Applied to next/fixes-non-critical with your Ack, thanks!
Arnd
^ permalink raw reply [flat|nested] 65+ messages in thread
* [PATCH 15/15] iscsi-target: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-11 16:56 ` Julia Lawall
-1 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: kernel-janitors, linux-scsi, target-devel, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/target/iscsi/iscsi_target.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -2155,7 +2155,6 @@ reject:
cmd->text_in_ptr = NULL;
return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf);
}
-EXPORT_SYMBOL(iscsit_handle_text_cmd);
int iscsit_logout_closesession(struct iscsi_cmd *cmd, struct iscsi_conn *conn)
{
^ permalink raw reply [flat|nested] 65+ messages in thread* [PATCH 15/15] iscsi-target: don't export static symbol
@ 2015-03-11 16:56 ` Julia Lawall
0 siblings, 0 replies; 65+ messages in thread
From: Julia Lawall @ 2015-03-11 16:56 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: kernel-janitors, linux-scsi, target-devel, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@
-EXPORT_SYMBOL(f);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/target/iscsi/iscsi_target.c | 1 -
1 file changed, 1 deletion(-)
diff -u -p a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
--- a/drivers/target/iscsi/iscsi_target.c
+++ b/drivers/target/iscsi/iscsi_target.c
@@ -2155,7 +2155,6 @@ reject:
cmd->text_in_ptr = NULL;
return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf);
}
-EXPORT_SYMBOL(iscsit_handle_text_cmd);
int iscsit_logout_closesession(struct iscsi_cmd *cmd, struct iscsi_conn *conn)
{
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 15/15] iscsi-target: don't export static symbol
2015-03-11 16:56 ` Julia Lawall
@ 2015-03-20 18:42 ` Nicholas A. Bellinger
-1 siblings, 0 replies; 65+ messages in thread
From: Nicholas A. Bellinger @ 2015-03-20 18:42 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, linux-scsi, target-devel, linux-kernel
On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/target/iscsi/iscsi_target.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff -u -p a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -2155,7 +2155,6 @@ reject:
> cmd->text_in_ptr = NULL;
> return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf);
> }
> -EXPORT_SYMBOL(iscsit_handle_text_cmd);
>
> int iscsit_logout_closesession(struct iscsi_cmd *cmd, struct iscsi_conn *conn)
> {
>
Applied to target-pending/for-next.
Thanks Julia!
--nab
^ permalink raw reply [flat|nested] 65+ messages in thread* Re: [PATCH 15/15] iscsi-target: don't export static symbol
@ 2015-03-20 18:42 ` Nicholas A. Bellinger
0 siblings, 0 replies; 65+ messages in thread
From: Nicholas A. Bellinger @ 2015-03-20 18:42 UTC (permalink / raw)
To: Julia Lawall; +Cc: kernel-janitors, linux-scsi, target-devel, linux-kernel
On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL;
> @@
>
> -EXPORT_SYMBOL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/target/iscsi/iscsi_target.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff -u -p a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c
> @@ -2155,7 +2155,6 @@ reject:
> cmd->text_in_ptr = NULL;
> return iscsit_reject_cmd(cmd, ISCSI_REASON_PROTOCOL_ERROR, buf);
> }
> -EXPORT_SYMBOL(iscsit_handle_text_cmd);
>
> int iscsit_logout_closesession(struct iscsi_cmd *cmd, struct iscsi_conn *conn)
> {
>
Applied to target-pending/for-next.
Thanks Julia!
--nab
^ permalink raw reply [flat|nested] 65+ messages in thread