From: George Joseph <george.joseph@fairview5.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Nimrod Andy <B38611@freescale.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Frank Li <Frank.Li@freescale.com>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: [PATCH 1/1] net: fec: fix oops after transmit queue timeout
Date: Wed, 11 Mar 2015 11:00:15 -0600 [thread overview]
Message-ID: <1426093216-18370-1-git-send-email-george.joseph@fairview5.com> (raw)
When a transmit queue timeout happens, dev_watchdog calls fec_timeout
which in turns schedules fec_enet_timeout_work. fec_enet_timeout_work
uses container_of to get the private data structure (fep) then tries to
use fep->netdev. Unfortunately, nobody ever set fep->netdev so the result
is a NULL pointer oops.
With fep->netdev set right after fep is allocated in fep_probe, the
drivers recovers nicely after the tx queue timeout.
Signed-off-by: George Joseph <george.joseph@fairview5.com>
Tested-by: George Joseph <george.joseph@fairview5.com>
---
drivers/net/ethernet/freescale/fec_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 3dca494..f6392ad 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3161,6 +3161,7 @@ fec_probe(struct platform_device *pdev)
/* setup board info structure */
fep = netdev_priv(ndev);
+ fep->netdev = ndev;
fep->num_rx_queues = num_rx_qs;
fep->num_tx_queues = num_tx_qs;
--
2.1.0
next reply other threads:[~2015-03-11 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 17:00 George Joseph [this message]
2015-03-11 17:12 ` [PATCH 1/1] net: fec: fix oops after transmit queue timeout Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426093216-18370-1-git-send-email-george.joseph@fairview5.com \
--to=george.joseph@fairview5.com \
--cc=B38611@freescale.com \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.