From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754419AbbCLONk (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Mar 2015 10:13:40 -0400
Received: from smtprelay0163.hostedemail.com ([216.40.44.163]:46006 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1754025AbbCLONi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Mar 2015 10:13:38 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::,RULES_HIT:41:355:379:541:599:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3870:3871:3872:3874:4321:5007:6261:9010:10004:10400:10848:11232:11658:11914:12517:12519:12555:12740:13019:13069:13311:13357:21067:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: neck54_59cce28ab5554
X-Filterd-Recvd-Size: 1400
Message-ID: <1426169615.32696.103.camel@perches.com>
Subject: Re: [PATCH] checkpatch: remove unneeded or ("|")
From: Joe Perches <joe@perches.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Date: Thu, 12 Mar 2015 07:13:35 -0700
In-Reply-To: <1426169269-15332-1-git-send-email-borntraeger@de.ibm.com>
References: <1426169269-15332-1-git-send-email-borntraeger@de.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-03-12 at 15:07 +0100, Christian Borntraeger wrote:
> while porting commit 89a883530fe7 ("checkpatch: ## is not a valid
> modifier") to QEMU, Peter Maydell noticed that the | at the end of
> the list is not necessary.
> 
> Lets get rid of it in kernel checkpatch.pl

Andy?  Was that meant to allow nothing?

> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -1550,7 +1550,7 @@ sub possible {
>  			asm|__asm__|
>  			do|
>  			\#|
> -			\#\#|
> +			\#\#
>  		)(?:\s|$)|
>  		^(?:typedef|struct|enum)\b
>  	    )}x;