All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Benjamin Romer <benjamin.romer@unisys.com>,
	David Kershner <david.kershner@unisys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: [PATCH v2 2/4] staging: unisys: dev_t initialization
Date: Thu, 12 Mar 2015 23:00:10 +0530	[thread overview]
Message-ID: <1426181412-19112-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1426181412-19112-1-git-send-email-sudipm.mukherjee@gmail.com>

dev_t is defined to be of unsigned int type, no use initializing
it to -1.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
v2: it was not in v1

 drivers/staging/unisys/visorchipset/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorchipset/file.c b/drivers/staging/unisys/visorchipset/file.c
index 9ca7f1e..e9459af 100644
--- a/drivers/staging/unisys/visorchipset/file.c
+++ b/drivers/staging/unisys/visorchipset/file.c
@@ -30,7 +30,7 @@
 
 static struct cdev file_cdev;
 static struct visorchannel **file_controlvm_channel;
-static dev_t majordev = -1; /**< indicates major num for device */
+static dev_t majordev; /**< indicates major num for device */
 static BOOL registered = FALSE;
 
 static int visorchipset_open(struct inode *inode, struct file *file);
-- 
1.8.1.2


  reply	other threads:[~2015-03-12 17:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 17:30 [PATCH v2 1/4] staging: unisys: remove unused variables Sudip Mukherjee
2015-03-12 17:30 ` Sudip Mukherjee [this message]
2015-03-16 15:36   ` [PATCH v2 2/4] staging: unisys: dev_t initialization Greg Kroah-Hartman
2015-03-24  8:14     ` Dan Carpenter
2015-03-12 17:30 ` [PATCH v2 3/4] staging: unisys: remove comparison Sudip Mukherjee
2015-03-12 17:30 ` [PATCH v2 4/4] staging: unisys: remove forward declarations Sudip Mukherjee
2015-03-16 15:35 ` [PATCH v2 1/4] staging: unisys: remove unused variables Greg Kroah-Hartman
2015-03-17  7:21   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426181412-19112-2-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.