From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915AbbCMImG (ORCPT ); Fri, 13 Mar 2015 04:42:06 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:53467 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750887AbbCMImD (ORCPT ); Fri, 13 Mar 2015 04:42:03 -0400 From: Wang Nan To: , , CC: , , , Subject: [PATCH] perf: fix a segfault problem. Date: Fri, 13 Mar 2015 08:41:32 +0000 Message-ID: <1426236092-197137-1-git-send-email-wangnan0@huawei.com> X-Mailer: git-send-email 1.8.3.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.107.197.200] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A0C0203.5502A2CC.0104,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: e96fa7d9083aae33199bb549fda63d03 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Without this patch, perf report cause segfault if pass "" as '-t': $ perf report -t "" # To display the perf.data header info, please use --header/--header-only options. # # Samples: 37 of event 'syscalls:sys_enter_write' # Event count (approx.): 37 # # Children SelfCommand Shared Object Symbol Segmentation fault This patch avoid the segfault by checking empty string for 'symbol_conf.field_sep'. Signed-off-by: Wang Nan --- tools/perf/util/sort.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index 4593f36..7f563a0 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -31,7 +31,8 @@ static int repsep_snprintf(char *bf, size_t size, const char *fmt, ...) va_start(ap, fmt); n = vsnprintf(bf, size, fmt, ap); - if (symbol_conf.field_sep && n > 0) { + if (symbol_conf.field_sep && n > 0 && + (symbol_conf.field_sep[0] != '\0')) { char *sep = bf; while (1) { -- 1.8.3.4