From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: Xen-unstable: "root=" no longer prepended on kernel
 cmdline since commit "tools: xl: handle unspecified extra= when dealing
 with root="
Date: Fri, 13 Mar 2015 10:23:47 +0000
Message-ID: <1426242227.32572.105.camel@citrix.com>
References: <11710414367.20150312184806@eikelenboom.it>
	<1426183146.32572.77.camel@citrix.com>
	<20150313100545.GC20896@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YWMkx-0006DJ-R0
	for xen-devel@lists.xenproject.org; Fri, 13 Mar 2015 10:23:51 +0000
In-Reply-To: <20150313100545.GC20896@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Sander Eikelenboom <linux@eikelenboom.it>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-03-13 at 10:05 +0000, Wei Liu wrote:
> On Thu, Mar 12, 2015 at 05:59:06PM +0000, Ian Campbell wrote:
> > On Thu, 2015-03-12 at 18:48 +0100, Sander Eikelenboom wrote:
> > > Hi Ian,
> > > 
> > > My PV-guest configs were still using the old "root=" option,
> > > but these guests don't boot anymore since:
> > > commit 49ab17a3a615e1ab4ccc46d6942f925cf841df4b,
> > > "tools: xl: handle unspecified extra= when dealing with root="
> > > 
> > > These pv guests don't boot anymore since the "root=" part isn't
> > > prepended anymore on the kernel commandline, leading to
> > > a guest kernel that is incapable of finding the root partition.
> > 
> > Bugger, you are of course absolutely correct.
> > 
> > How about this, compile tested only...
> > 
> > 8<-------------
> > 
> > >From fc8eed8083d87608df7b836d89ba058066206b6c Mon Sep 17 00:00:00 2001
> > From: Ian Campbell <ian.campbell@citrix.com>
> > Date: Thu, 12 Mar 2015 17:56:47 +0000
> > Subject: [PATCH] tools: xl: prepend root= to root field on command line with
> >  no extra
> > 
> > This was broken in 49ab17a3a615 "tools: xl: handle unspecified extra=
> > when dealing with root=".
> > 
> > Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Applied, with a tested-by from Sander too.