From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWdNF-00005j-7B for qemu-devel@nongnu.org; Sat, 14 Mar 2015 00:08:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YWdNE-00087z-6X for qemu-devel@nongnu.org; Sat, 14 Mar 2015 00:08:29 -0400 Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:36158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YWdNE-00087n-0F for qemu-devel@nongnu.org; Sat, 14 Mar 2015 00:08:28 -0400 Received: by padcy3 with SMTP id cy3so7333396pad.3 for ; Fri, 13 Mar 2015 21:08:27 -0700 (PDT) From: sfeldma@gmail.com Date: Fri, 13 Mar 2015 21:09:26 -0700 Message-Id: <1426306173-24884-3-git-send-email-sfeldma@gmail.com> In-Reply-To: <1426306173-24884-1-git-send-email-sfeldma@gmail.com> References: <1426306173-24884-1-git-send-email-sfeldma@gmail.com> Subject: [Qemu-devel] [PATCH v8 2/9] virtio-net: use qemu_mac_strdup_printf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, stefanha@gmail.com Cc: jiri@resnulli.us, roopa@cumulusnetworks.com, john.fastabend@gmail.com, dsahern@gmail.com, pbonzini@redhat.com, jasowang@redhat.com From: Scott Feldman Signed-off-by: Scott Feldman Reviewed-by: Eric Blake --- hw/net/virtio-net.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 27adcc5..321bef4 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -226,12 +226,6 @@ static void rxfilter_notify(NetClientState *nc) } } -static char *mac_strdup_printf(const uint8_t *mac) -{ - return g_strdup_printf("%.2x:%.2x:%.2x:%.2x:%.2x:%.2x", mac[0], - mac[1], mac[2], mac[3], mac[4], mac[5]); -} - static intList *get_vlan_table(VirtIONet *n) { intList *list, *entry; @@ -284,12 +278,12 @@ static RxFilterInfo *virtio_net_query_rxfilter(NetClientState *nc) info->multicast_overflow = n->mac_table.multi_overflow; info->unicast_overflow = n->mac_table.uni_overflow; - info->main_mac = mac_strdup_printf(n->mac); + info->main_mac = qemu_mac_strdup_printf(n->mac); str_list = NULL; for (i = 0; i < n->mac_table.first_multi; i++) { entry = g_malloc0(sizeof(*entry)); - entry->value = mac_strdup_printf(n->mac_table.macs + i * ETH_ALEN); + entry->value = qemu_mac_strdup_printf(n->mac_table.macs + i * ETH_ALEN); entry->next = str_list; str_list = entry; } @@ -298,7 +292,7 @@ static RxFilterInfo *virtio_net_query_rxfilter(NetClientState *nc) str_list = NULL; for (i = n->mac_table.first_multi; i < n->mac_table.in_use; i++) { entry = g_malloc0(sizeof(*entry)); - entry->value = mac_strdup_printf(n->mac_table.macs + i * ETH_ALEN); + entry->value = qemu_mac_strdup_printf(n->mac_table.macs + i * ETH_ALEN); entry->next = str_list; str_list = entry; } -- 1.7.10.4