All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brad Campbell <bradjc5@gmail.com>
To: linux-wpan@vger.kernel.org
Cc: alex.aring@gmail.com, Brad Campbell <bradjc5@gmail.com>
Subject: [PATCHv2 0/2] cc2520: add support for CC2591
Date: Mon, 16 Mar 2015 18:16:41 -0400	[thread overview]
Message-ID: <1426544203-60585-1-git-send-email-bradjc5@gmail.com> (raw)

Hi,

I've updated the patch. I changed the `amplified` param to be a bool            
which was straightforward once I learned that device tree entries can           
have empty properties.                                                          
                                                                                
I added a second commit that should take of the issue of platform_data not      
being read-only in cc2520_hw_init. Let me know if I can improve it, although    
it is mostly copied from the at86rf230.c version. I didn't think it was         
necessary to pass each item in the cc2520_platform_data struct individually     
and instead just pass the struct to get_platform_data.                          
                                                                                
I have tested the patch with both a CC2520 and a CC2520+CC2591 combination.     
The patch boils down to just sending different register settings for the        
CC2520 and seems to work because I can send and receive with both radios.       
                                                                                
Thank you for looking over the patch and let me know if there is anything       
else I should fix.

Brad

changes since v1:
- change how platform_data is handled
- make amplified a bool instead of int

Brad Campbell (2):
  cc2520: Do not store platform_data in spi_device
  cc2520: Add support for CC2591 amplifier.

 .../devicetree/bindings/net/ieee802154/cc2520.txt  |   4 +
 drivers/net/ieee802154/cc2520.c                    | 148 +++++++++++++--------
 include/linux/spi/cc2520.h                         |   1 +
 3 files changed, 96 insertions(+), 57 deletions(-)

-- 
2.3.2


             reply	other threads:[~2015-03-16 22:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 22:16 Brad Campbell [this message]
2015-03-16 22:16 ` [PATCHv2 1/2] cc2520: Do not store platform_data in spi_device Brad Campbell
2015-03-17  8:06   ` Alexander Aring
2015-03-16 22:16 ` [PATCHv2 2/2] cc2520: Add support for CC2591 amplifier Brad Campbell
2015-03-17  8:03   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426544203-60585-1-git-send-email-bradjc5@gmail.com \
    --to=bradjc5@gmail.com \
    --cc=alex.aring@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.