Re: [PATCH REGRESSION FIX] x86 idle: restore mwait_idle()

From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Ian Malone <ibmalone@gmail.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Len Brown <lenb@kernel.org>,
	x86@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
	Josh Boyer <jwboyer@redhat.com>,
	stable@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH REGRESSION FIX] x86 idle: restore mwait_idle()
Date: Tue, 17 Mar 2015 09:33:02 +0100	[thread overview]
Message-ID: <1426581182.6690.6.camel@gmail.com> (raw)
In-Reply-To: <20150317082203.GC28462@gmail.com>

On Tue, 2015-03-17 at 09:22 +0100, Ingo Molnar wrote:
> * Ian Malone <ibmalone@gmail.com> wrote:
> 
> > On 15 March 2015 at 04:53, Mike Galbraith <umgwanakikbuti@gmail.com> wrote:
> > > On Sat, 2015-03-14 at 23:44 +0000, Ian Malone wrote:
> > >> On 18 January 2014 at 16:14, Mike Galbraith <bitbucket@online.de> wrote:
> > >> > On Sat, 2014-01-18 at 10:33 +0100, Mike Galbraith wrote:
> > >> >> On Fri, 2014-01-17 at 05:20 +0100, Mike Galbraith wrote:
> > >>
> > >> > Signed-off-by: Mike Galbraith <bitbucket@online.de>
> > >> > Cc: <stable@vger.kernel.org> # 3.10+
> > >> > ---
> > >> >  arch/x86/kernel/process.c |    9 ++++++---
> > >> >  1 file changed, 6 insertions(+), 3 deletions(-)
> > >> >
> > >> > --- a/arch/x86/kernel/process.c
> > >> > +++ b/arch/x86/kernel/process.c
> > >> > @@ -427,18 +427,21 @@ static int prefer_mwait_c1_over_halt(con
> > >>
> > >> Hi, this series of patches never seem to have made it as far as the
> > >> mainline kernel, anyone know what needs to happen next?
> > >
> > > My plan is to keep on carrying it locally for as long as I run new
> > > kernels on crusty ole core2 boxen, then stop caring about them entirely
> > > like the rest of the planet :)
> > >
> > 
> > Looks like Ingo Molnar has committed to tip which is probably a good
> > sign, thanks all.
> > (Have to hand this system on to someone who wont be patching kernels...)
> 
> Guys, since I don't have the affected hardware, mind testing the 
> latest sched/core tree:
> 
>   git clone git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
>   cd tip
>   git checkout sched/core
>   # build a test kernel and boot it
> 
> Or if you already have a kernel git tree, do something like this to 
> pick up the scheduler development tree:
> 
>   cd linux.git
>   git remote add git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tip
>   git remote update
>   git checkout tip/sched/core
>   # build a test kernel and boot it
> 
> and check whether the mwait related bugs are now fixed for good?

"marge" (Q6600 box) is mostly retired now, but I'll kick her out of her
rocking chair as soon as I can escape from bugzilla.  All should be
well, as she's been running it for ages, and ran it in master just a
couple days ago.

	-Mike