From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXtS9-0002cF-Kj for qemu-devel@nongnu.org; Tue, 17 Mar 2015 11:30:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXtS3-0003p7-BA for qemu-devel@nongnu.org; Tue, 17 Mar 2015 11:30:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXtS3-0003p2-5z for qemu-devel@nongnu.org; Tue, 17 Mar 2015 11:30:39 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id C1057314124 for ; Tue, 17 Mar 2015 15:30:38 +0000 (UTC) From: Juan Quintela Date: Tue, 17 Mar 2015 16:30:23 +0100 Message-Id: <1426606235-7238-2-git-send-email-quintela@redhat.com> In-Reply-To: <1426606235-7238-1-git-send-email-quintela@redhat.com> References: <1426606235-7238-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PULL 01/13] migration: Avoid qerror_report_err() outside QMP command handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Markus Armbruster From: Markus Armbruster qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in process_incoming_migration_co(). Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Signed-off-by: Juan Quintela --- migration/migration.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 2c805f1..60da9fe 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -123,8 +123,7 @@ static void process_incoming_migration_co(void *opaque) /* Make sure all file formats flush their mutable metadata */ bdrv_invalidate_cache_all(&local_err); if (local_err) { - qerror_report_err(local_err); - error_free(local_err); + error_report_err(local_err); exit(EXIT_FAILURE); } -- 2.1.0