From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755803AbbCRKfh (ORCPT ); Wed, 18 Mar 2015 06:35:37 -0400 Received: from cpsmtpb-ews09.kpnxchange.com ([213.75.39.14]:61229 "EHLO cpsmtpb-ews09.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754074AbbCRKfd (ORCPT ); Wed, 18 Mar 2015 06:35:33 -0400 Message-ID: <1426674930.2649.50.camel@tiscali.nl> Subject: Re: [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller From: Paul Bolle To: Fabrice Gasnier Cc: Gabriel FERNANDEZ , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Bjorn Helgaas , Mohit Kumar , Jingoo Han , Lucas Stach , Kishon Vijay Abraham I , Andrew Morton , "David S. Miller" , Greg KH , Mauro Carvalho Chehab , Joe Perches , Tejun Heo , Arnd Bergmann , Viresh Kumar , Thierry Reding , Phil Edworthy , Minghuan Lian , Tanmay Inamdar , m-karicheri2@ti.com, Sachin Kamat , Andrew Lunn , Liviu Dudau , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com, linux-pci@vger.kernel.org, Lee Jones , Gabriel Fernandez Date: Wed, 18 Mar 2015 11:35:30 +0100 In-Reply-To: <55093C12.7070004@st.com> References: <1426515635-9466-1-git-send-email-gabriel.fernandez@linaro.org> <1426515635-9466-4-git-send-email-gabriel.fernandez@linaro.org> <1426518695.26437.55.camel@x220> <55093C12.7070004@st.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 18 Mar 2015 10:35:31.0330 (UTC) FILETIME=[4229B620:01D06167] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabrice, Fabrice Gasnier schreef op wo 18-03-2015 om 09:49 [+0100]: > On 03/16/2015 04:11 PM, Paul Bolle wrote: > >> +config PCI_ST > >> + bool "ST PCIe controller" > > You add a bool Kconfig symbol. A week or two ago I saw some patches fly > > by that - I think - allowed PCIe controllers to be built modular. > > Thanks for your review. > > Are you talking about "PCI: Export symbols of PCI functions" patch, that > is part of a series > named "pci: iproc: Add Broadcom iProc PCIe support" ? Yes, that is the series I was thinking about. (I made you search lkml, and that was a bit rude. But you found the patch anyhow.) > This controller doesn't look like to be based on pcie-designware core > driver. > Other vendors that are using "pcie-designware" core driver are also make > it bool. > The current core driver doesn't support module loading/unloading as I > see it. > If this is required, I also think this should be part of another patchset. > > What do you think ? I wouldn't know whether your driver might work as a loadable module, but other people reading this surely will. But if it can't work as a module you should drop all the module related macros etc. I spotted. Because then they serve no purpose. Paul Bolle From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Bolle Subject: Re: [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller Date: Wed, 18 Mar 2015 11:35:30 +0100 Message-ID: <1426674930.2649.50.camel@tiscali.nl> References: <1426515635-9466-1-git-send-email-gabriel.fernandez@linaro.org> <1426515635-9466-4-git-send-email-gabriel.fernandez@linaro.org> <1426518695.26437.55.camel@x220> <55093C12.7070004@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55093C12.7070004@st.com> Sender: linux-pci-owner@vger.kernel.org To: Fabrice Gasnier Cc: Gabriel FERNANDEZ , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Russell King , Bjorn Helgaas , Mohit Kumar , Jingoo Han , Lucas Stach , Kishon Vijay Abraham I , Andrew Morton , "David S. Miller" , Greg KH , Mauro Carvalho Chehab , Joe Perches , Tejun Heo , Arnd Bergmann , Viresh Kumar List-Id: devicetree@vger.kernel.org Hi Fabrice, Fabrice Gasnier schreef op wo 18-03-2015 om 09:49 [+0100]: > On 03/16/2015 04:11 PM, Paul Bolle wrote: > >> +config PCI_ST > >> + bool "ST PCIe controller" > > You add a bool Kconfig symbol. A week or two ago I saw some patches fly > > by that - I think - allowed PCIe controllers to be built modular. > > Thanks for your review. > > Are you talking about "PCI: Export symbols of PCI functions" patch, that > is part of a series > named "pci: iproc: Add Broadcom iProc PCIe support" ? Yes, that is the series I was thinking about. (I made you search lkml, and that was a bit rude. But you found the patch anyhow.) > This controller doesn't look like to be based on pcie-designware core > driver. > Other vendors that are using "pcie-designware" core driver are also make > it bool. > The current core driver doesn't support module loading/unloading as I > see it. > If this is required, I also think this should be part of another patchset. > > What do you think ? I wouldn't know whether your driver might work as a loadable module, but other people reading this surely will. But if it can't work as a module you should drop all the module related macros etc. I spotted. Because then they serve no purpose. Paul Bolle From mboxrd@z Thu Jan 1 00:00:00 1970 From: pebolle@tiscali.nl (Paul Bolle) Date: Wed, 18 Mar 2015 11:35:30 +0100 Subject: [PATCH v2 3/5] PCI: st: Provide support for the sti PCIe controller In-Reply-To: <55093C12.7070004@st.com> References: <1426515635-9466-1-git-send-email-gabriel.fernandez@linaro.org> <1426515635-9466-4-git-send-email-gabriel.fernandez@linaro.org> <1426518695.26437.55.camel@x220> <55093C12.7070004@st.com> Message-ID: <1426674930.2649.50.camel@tiscali.nl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Fabrice, Fabrice Gasnier schreef op wo 18-03-2015 om 09:49 [+0100]: > On 03/16/2015 04:11 PM, Paul Bolle wrote: > >> +config PCI_ST > >> + bool "ST PCIe controller" > > You add a bool Kconfig symbol. A week or two ago I saw some patches fly > > by that - I think - allowed PCIe controllers to be built modular. > > Thanks for your review. > > Are you talking about "PCI: Export symbols of PCI functions" patch, that > is part of a series > named "pci: iproc: Add Broadcom iProc PCIe support" ? Yes, that is the series I was thinking about. (I made you search lkml, and that was a bit rude. But you found the patch anyhow.) > This controller doesn't look like to be based on pcie-designware core > driver. > Other vendors that are using "pcie-designware" core driver are also make > it bool. > The current core driver doesn't support module loading/unloading as I > see it. > If this is required, I also think this should be part of another patchset. > > What do you think ? I wouldn't know whether your driver might work as a loadable module, but other people reading this surely will. But if it can't work as a module you should drop all the module related macros etc. I spotted. Because then they serve no purpose. Paul Bolle