All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Charles Arnold <carnold@suse.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] xentop: add support for qdisks
Date: Fri, 20 Mar 2015 09:57:02 +0000	[thread overview]
Message-ID: <1426845422.21742.114.camel@citrix.com> (raw)
In-Reply-To: <550ACD3102000091000F2C93@prv-mh.provo.novell.com>

On Thu, 2015-03-19 at 13:20 -0600, Charles Arnold wrote:
> >>> On 3/19/2015 at 12:09 PM, Anthony PERARD <anthony.perard@citrix.com> wrote: 
> > On Wed, Mar 18, 2015 at 04:12:26PM +0000, Ian Campbell wrote:
> >> My second concern here is with the use of /var/run/xen/qmp-libxl-%i from
> >> outside of libxl. I can't remember if qemu is safe against multiple
> >> users of the socket. ISTR asking Anthony this before, but I don't recall
> >> the answer, sorry :-(
> > 
> > Last time I checked, only one client at a time can connect to the socket.
> > If a second user want to connect to the socket, it will be blocked until
> > the first one disconnect.
> 
> This seems correct based on some of my testing.  In rare cases (perhaps not so
> rare for VMs under heavy I/O load), reading the socket to get the stats times out
> and so xentop will report '0' for the read/write stats until the next read attempt
> that succeeds.
> 
> It looks as if we do need a second socket to qemu.  I will include that in the next
> patch version.

Yep, it sounds like it is a requirement, thanks.

Ian.

      reply	other threads:[~2015-03-20  9:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11 17:51 [PATCH v2] xentop: add support for qdisks Charles Arnold
2015-03-18 16:12 ` Ian Campbell
2015-03-19 17:50   ` Charles Arnold
2015-03-20  9:56     ` Ian Campbell
2015-03-19 18:09   ` Anthony PERARD
2015-03-19 19:20     ` Charles Arnold
2015-03-20  9:57       ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426845422.21742.114.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=carnold@suse.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.