From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751724AbbCTKXj (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 Mar 2015 06:23:39 -0400
Received: from cpsmtpb-ews04.kpnxchange.com ([213.75.39.7]:61782 "EHLO
	cpsmtpb-ews04.kpnxchange.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751332AbbCTKXg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Mar 2015 06:23:36 -0400
Message-ID: <1426847014.23529.35.camel@x220>
Subject: Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK
From: Paul Bolle <pebolle@tiscali.nl>
To: Guenter Roeck <linux@roeck-us.net>
Cc: valentinrothberg@gmail.com, rupran@einserver.de, stefan.hengelein@fau.de,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org,
        Vladimir Murzin <vladimir.murzin@arm.com>
Date: Fri, 20 Mar 2015 11:23:34 +0100
In-Reply-To: <1426237389-10093-1-git-send-email-linux@roeck-us.net>
References: <1426237389-10093-1-git-send-email-linux@roeck-us.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 20 Mar 2015 10:23:34.0438 (UTC) FILETIME=[EBB02C60:01D062F7]
X-RcptDomain: vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2015-03-13 at 02:03 -0700, Guenter Roeck wrote:
> Building alpha:allmodconfig fails with
> 
> mm/memtest.c: In function 'reserve_bad_mem':
> mm/memtest.c:38:2: error: implicit declaration of function 'memblock_reserve'
> mm/memtest.c: In function 'do_one_pass':
> mm/memtest.c:77:2: error: implicit declaration of function 'for_each_free_mem_range'
> mm/memtest.c:77:73: error: expected ';' before '{' token
> 
> because it depends on MEMBLOCK which is not defined for the alpha
> architecture.
> 
> Fixes: 420c89e6185d ("mm: move memtest under mm")
> Cc: Vladimir Murzin <vladimir.murzin@arm.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  lib/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8b4e69a..dc1e69c 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1797,6 +1797,7 @@ config TEST_UDELAY
>  
>  config MEMTEST
>  	bool "Memtest"
> +	depends on MEMBLOCK
>  	---help---
>  	  This option adds a kernel parameter 'memtest', which allows memtest
>  	  to be set.

(There's now a bot checking this stuff, but I couldn't resist reporting
it when my script spotted it.)

Please do
    $ git grep -n "config\s\+MEMBLOCK\b" next-20150320
    $ git grep -n "config\s\+MEMBLOCK\b" v4.0-rc4

I think this patch simply disables MEMTEST altogether. I'm guessing this
should have added
	depends on HAVE_MEMBLOCK


Paul Bolle