From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585AbbCTPLc (ORCPT ); Fri, 20 Mar 2015 11:11:32 -0400 Received: from cpsmtpb-ews03.kpnxchange.com ([213.75.39.6]:56792 "EHLO cpsmtpb-ews03.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbbCTPL3 (ORCPT ); Fri, 20 Mar 2015 11:11:29 -0400 Message-ID: <1426864287.23529.84.camel@x220> Subject: Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK From: Paul Bolle To: Stefan Hengelein Cc: Vladimir Murzin , Guenter Roeck , "valentinrothberg@gmail.com" , "rupran@einserver.de" , Andrew Morton , "linux-kernel@vger.kernel.org" Date: Fri, 20 Mar 2015 16:11:27 +0100 In-Reply-To: References: <1426237389-10093-1-git-send-email-linux@roeck-us.net> <1426847014.23529.35.camel@x220> <550BF8E2.9020002@arm.com> <1426848726.23529.41.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 20 Mar 2015 15:11:27.0741 (UTC) FILETIME=[23610AD0:01D06320] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-03-20 at 15:34 +0100, Stefan Hengelein wrote: > 2015-03-20 11:52 GMT+01:00 Paul Bolle : > > Valentin proposed an update to scripts/checkkconfigsymbols.py in > > https://lkml.org/lkml/2015/3/16/190 . It (or something like it) should > > have helped testing for typos like that: > > python scripts/checkkconfigsymbols.py --commit b47818820b392273da5470975a29aca4cba92cb4 > > MEMBLOCK lib/Kconfig.debug > > > > Which is actually rather cool! > > > Would it be reasonable to add an entry (or expand entry 8) in > Documentation/SubmitChecklist to point to the script? > "If your patch has changed conditions in Kconfig, run "python > scripts/checkkconfigsymbols.py --commit $your_commit"" ? That's not for me to decide. However, I would suggest you wait a bit before adding it to that list (or any other piece of Documentation). Just to be sure it works for most people. Once that update has hit linux-next, you can point patch authors to it every time the bot finds something the script would have caught too. That should enlarge the pool of users. And, as complaints tend to be voiced loud and clear, that in turn should help shake out any bugs or ill considered features. Paul Bolle