From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Date: Fri, 20 Mar 2015 19:28:16 -0500 Subject: [U-Boot] [PATCH v4 24/28] armv8/ls2085aqds: NAND boot support In-Reply-To: <20150321001803.GL32541@bill-the-cat> References: <1426879262-32573-1-git-send-email-yorksun@freescale.com> <1426879262-32573-2-git-send-email-yorksun@freescale.com> <1426886140.27998.206.camel@freescale.com> <20150320213740.GK32541@bill-the-cat> <1426887859.27998.225.camel@freescale.com> <20150321001803.GL32541@bill-the-cat> Message-ID: <1426897696.27998.251.camel@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, 2015-03-20 at 20:18 -0400, Tom Rini wrote: > On Fri, Mar 20, 2015 at 04:44:19PM -0500, Scott Wood wrote: > > On Fri, 2015-03-20 at 17:37 -0400, Tom Rini wrote: > > > On Fri, Mar 20, 2015 at 04:15:40PM -0500, Scott Wood wrote: > > > > > > [snip] > > > > It would also be nice to sort out loading the environment during SPL. > > > > > > *ears perk up*. Please elaborate :) We have SPL environment support, > > > we have SPL NAND Environment support today. It doesn't get passed along > > > to the running U-Boot and it's used for some limited cases (network and > > > redundancy). I'd like to hear about more and better ways of using it. > > > > In common/spl/spl_nand.c, why does it only load the environment when > > CONFIG_NAND_ENV_DST is defined, yet it never uses the value of > > CONFIG_NAND_ENV_DST? I also don't see any boards definind > > CONFIG_NAND_ENV_DST (apparently the only one that ever used it was > > smdk6400 which has been removed). > > > > Is there some other way that the environment is supposed to be getting > > loaded from NAND (rather than using the default environment) during SPL? > > Yeah, it's loaded via env_init() being called (see spl_net.c or > board/ti/). The NAND version of env_init() does not access NAND. It loads from CONFIG_NAND_ENV_DST (but again, no board sets that) or from an embedded environment. -Scott