From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Hershberger Date: Sun, 22 Mar 2015 17:09:04 -0500 Subject: [U-Boot] [PATCH v7 07/27] net: Change return codes from net/eth.c to use errorno constants In-Reply-To: <1427062165-17838-1-git-send-email-joe.hershberger@ni.com> References: <1426117465-16072-1-git-send-email-joe.hershberger@ni.com> <1427062165-17838-1-git-send-email-joe.hershberger@ni.com> Message-ID: <1427062165-17838-8-git-send-email-joe.hershberger@ni.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Many functions returned -1 previously. Change them to return appropriate error codes. Signed-off-by: Joe Hershberger Reported-by: Simon Glass Reviewed-by: Simon Glass --- Changes in v7: None Changes in v6: None Changes in v5: None Changes in v4: -New to v4 Changes in v3: None Changes in v2: None net/eth.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/eth.c b/net/eth.c index 84919e0..9ad15cd 100644 --- a/net/eth.c +++ b/net/eth.c @@ -227,7 +227,7 @@ int eth_unregister(struct eth_device *dev) /* No device */ if (!eth_devices) - return -1; + return -ENODEV; for (cur = eth_devices; cur->next != eth_devices && cur->next != dev; cur = cur->next) @@ -235,7 +235,7 @@ int eth_unregister(struct eth_device *dev) /* Device not found */ if (cur->next != dev) - return -1; + return -ENODEV; cur->next = dev->next; @@ -368,7 +368,7 @@ int eth_init(bd_t *bis) if (!eth_current) { puts("No ethernet found.\n"); - return -1; + return -ENODEV; } /* Sync environment with network devices */ @@ -397,7 +397,7 @@ int eth_init(bd_t *bis) eth_try_another(0); } while (old_current != eth_current); - return -1; + return -ETIMEDOUT; } void eth_halt(void) @@ -413,7 +413,7 @@ void eth_halt(void) int eth_send(void *packet, int length) { if (!eth_current) - return -1; + return -ENODEV; return eth_current->send(eth_current, packet, length); } @@ -421,7 +421,7 @@ int eth_send(void *packet, int length) int eth_rx(void) { if (!eth_current) - return -1; + return -ENODEV; return eth_current->recv(eth_current); } -- 1.7.11.5