All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	linux-pci@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
	linux-kernel@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Russell King <linux@arm.linux.org.uk>,
	x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	linux-alpha@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	Liviu Dudau <liviu@dudau.co.uk>, Arnd Bergmann <arnd@arndb.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Yijing Wang <wangyijing@huawei.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Jason Cooper <jason@lakedaemon.net>
Subject: [PATCH v7 23/31] PCI/mvebu: Use pci_common_init_dev() to simplify code
Date: Mon, 23 Mar 2015 20:40:49 +0800	[thread overview]
Message-ID: <1427114457-16687-24-git-send-email-wangyijing__22626.1373878971$1427115136$gmane$org@huawei.com> (raw)
In-Reply-To: <1427114457-16687-1-git-send-email-wangyijing@huawei.com>

Mvebu_pcie_scan_bus() is not necessary, we could use
pci_common_init_dev() instead of pci_common_init(),
and pass the device pointer as the parent. Then
pci_scan_root_bus() will be called to scan the pci busses.

Signed-off-by: Yijing Wang <wangyijing@huawei.com>
CC: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
CC: Jason Cooper <jason@lakedaemon.net>
---
 drivers/pci/host/pci-mvebu.c |   18 +-----------------
 1 files changed, 1 insertions(+), 17 deletions(-)

diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
index 0cfc494..d5a2b70 100644
--- a/drivers/pci/host/pci-mvebu.c
+++ b/drivers/pci/host/pci-mvebu.c
@@ -750,21 +750,6 @@ static int mvebu_pcie_setup(int nr, struct pci_sys_data *sys)
 	return 1;
 }
 
-static struct pci_bus *mvebu_pcie_scan_bus(int nr, struct pci_sys_data *sys)
-{
-	struct mvebu_pcie *pcie = sys_to_pcie(sys);
-	struct pci_bus *bus;
-
-	bus = pci_create_root_bus(&pcie->pdev->dev, -1, sys->busnr,
-				  &mvebu_pcie_ops, sys, &sys->resources);
-	if (!bus)
-		return NULL;
-
-	pci_scan_child_bus(bus);
-
-	return bus;
-}
-
 static resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
 						 const struct resource *res,
 						 resource_size_t start,
@@ -808,12 +793,11 @@ static void mvebu_pcie_enable(struct mvebu_pcie *pcie)
 	hw.nr_controllers = 1;
 	hw.private_data   = (void **)&pcie;
 	hw.setup          = mvebu_pcie_setup;
-	hw.scan           = mvebu_pcie_scan_bus;
 	hw.map_irq        = of_irq_parse_and_map_pci;
 	hw.ops            = &mvebu_pcie_ops;
 	hw.align_resource = mvebu_pcie_align_resource;
 
-	pci_common_init(&hw);
+	pci_common_init_dev(&pcie->pdev->dev, &hw);
 }
 
 /*
-- 
1.7.1

  parent reply	other threads:[~2015-03-23 12:40 UTC|newest]

Thread overview: 191+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-23 12:40 [PATCH v7 00/31] Refine PCI scan interfaces and make generic pci host bridge Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 01/31] xen/PCI: Don't use deprecated function pci_scan_bus_parented() Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 02/31] PCI: Remove deprecated pci_scan_bus_parented() Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 03/31] PCI: Save domain in pci_host_bridge Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 04/31] PCI: Move pci_bus_assign_domain_nr() declaration into drivers/pci/pci.h Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 05/31] PCI: Introduce pci_host_assign_domain_nr() to assign domain Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 06/31] PCI: Separate pci_host_bridge creation out of pci_create_root_bus() Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 07/31] PCI: Add default bus resource in pci_host_bridge Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 08/31] PCI: Update pci_host_bridge bus resource Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 09/31] PCI: Introduce pci_host_first_busnr() function Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 10/31] PCI: Introduce pci_host_bridge_list to manage host bridges Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 11/31] PCI: Save sysdata in pci_host_bridge drvdata Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 12/31] powerpc/PCI: Rename pcibios_root_bridge_prepare() to pcibios_set_root_bus_speed() Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 13/31] PCI: Move pcibios_root_bridge_prepare() to pci_create_host_bridge() Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 14/31] PCI: Introduce pci_host_bridge_ops to support host specific operations Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 15/31] PCI: Introduce new scan function pci_scan_host_bridge() Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 16/31] PCI: Introduce pci_bus_child_max_busnr() Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 17/31] x86/PCI: Refine pci_acpi_scan_root() with generic pci_host_bridge Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 18/31] ia64/PCI: " Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 19/31] powerpc/pci: Use pci_scan_host_bridge() for simplicity Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 20/31] PCI: Remove pcibios_root_bridge_prepare() and pcibos_set_root_bus_speed() Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 21/31] sparc/PCI: Use pci_scan_host_bridge() for simplicity Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 22/31] parisc/PCI: Use pci_scan_root_bus() " Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 23/31] PCI/mvebu: Use pci_common_init_dev() to simplify code Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang [this message]
     [not found] ` <1427114457-16687-1-git-send-email-wangyijing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-03-23 12:40   ` [PATCH v7 24/31] PCI/tegra: Remove redundant tegra_pcie_scan_bus() Yijing Wang
2015-03-23 12:40     ` Yijing Wang
2015-03-23 12:40     ` Yijing Wang
2015-03-23 12:40     ` Yijing Wang
2015-03-23 12:40     ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 25/31] PCI/designware: Use pci_scan_root_bus() for simplicity Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 26/31] PCI/xgene: Use pci_scan_root_bus() instead of pci_create_root_bus() Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 27/31] PCI: Rename __pci_create_root_bus() to pci_create_root_bus() Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 28/31] PCI: rename to pci_find_host_bridge() Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 29/31] PCI: Remove platform specific pci_domain_nr() Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 30/31] PCI: Remove pci_bus_assign_domain_nr() Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40 ` [PATCH v7 31/31] PCI: Clean up CONFIG_PCI_DOMAINS_GENERIC Yijing Wang
2015-03-23 12:40 ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang
2015-03-23 12:40   ` Yijing Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1427114457-16687-24-git-send-email-wangyijing__22626.1373878971$1427115136$gmane$org@huawei.com' \
    --to=wangyijing@huawei.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=jason@lakedaemon.net \
    --cc=jiang.liu@linux.intel.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liviu@dudau.co.uk \
    --cc=marc.zyngier@arm.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.