From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 16/29] libxl: ao: Provide manip_refcnt
Date: Tue, 24 Mar 2015 11:32:02 +0000
Message-ID: <1427196722.21742.354.camel@citrix.com>
References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com>
	<1423599016-32639-17-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1423599016-32639-17-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Euan Harris <euan.harris@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote:
> +/*
> + * A "manip" is a libxl public function manipulating this ao, which
> + * has a pointer to it.  We have to not destroy it while that's the
> + * case, obviously.

It might be nice to the reader to make a reference to the "An ao and its
gc may be accessed only with the ctx lock held." sentence in the overall
ao docs?
[...]
> +        libxl__ao__destroy(ctx,ao);

Nit: missing space after ",".

But other than those and including if you disagree about extending the
comment, since it's not a big deal:
        Acked-by: Ian Campbell <ian.campbell@citrix.com>
        
Ian.