From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 17/29] libxl: cancellation: Provide public ao cancellation API Date: Tue, 24 Mar 2015 11:45:21 +0000 Message-ID: <1427197521.21742.357.camel@citrix.com> References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com> <1423599016-32639-18-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423599016-32639-18-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Euan Harris List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote: > +/* > + * It is sometimes possible to cancel an asynchronous operation. > + * > + * libxl_ao_cancel searches for an ongoing asynchronous operation whose > + * ao_how is identical to *how, and tries to cancel it. I can see that you have arranged for the pointer not to be required to match, just the contents of the struct, which may be convenient for some callers who haven't remembered the ao_how somewhere convenient, but is it permissible to use the same pointer if it is convenient? Other than wondering about that this patch looks good, Acked-by: Ian Campbell