From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 21/29] libxl: cancellation: Make spawns cancellable Date: Tue, 24 Mar 2015 11:53:42 +0000 Message-ID: <1427198022.21742.364.camel@citrix.com> References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com> <1423599016-32639-22-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423599016-32639-22-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Euan Harris List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote: > The libxl__spawn_spawn internal API permits the caller to specify > .timeout_ms==-1, meaning to wait forever. Provide an explicit > cancellable to allow spawns to be cancelled. AIUI this also lets spawns with timeout_ms > -1 to be cancelled, which I think is desirable. > I think there are not currently any internal callers which do use > spawn with an infinite timeout, but this should not be left as a > lacuna for later. > > Also, this change means that in practice anything which is cancelled > while spawning ought to be queued for two cancellation notifications: > one from its timeout, and one from the explicit cancellation > registration. Hopefully this will mean that more exciting paths are > exercised during testing. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell