From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 23/29] libxl: cancellation: Support cancellation where we spot domain death Date: Tue, 24 Mar 2015 11:58:35 +0000 Message-ID: <1427198315.21742.368.camel@citrix.com> References: <1423599016-32639-1-git-send-email-ian.jackson@eu.citrix.com> <1423599016-32639-24-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1423599016-32639-24-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xensource.com, Euan Harris List-Id: xen-devel@lists.xenproject.org On Tue, 2015-02-10 at 20:10 +0000, Ian Jackson wrote: > Make an active libxl__domaindeathcheck contain an active > libxl__ao_cancellable. > > Consequential changes are: > * domaindeath callbacks now take an rc value. > * libxl__domaindeathcheck_start takes an ao, not a gc. > * bootloader_domaindeath plumbs the rc through to its caller. > * libxl__domaindeathcheck_init and _stop are not quite trivial any > more so are moved from (inline functions) in libxl_internal.h, to > ordinary functions defined in libxl_event.c. > * libxl__domaindeathcheck_start is not trivial any more, and now has > the standard error-handling pattern. > > The only current user of libxl__domaindeathcheck is the bootloader. > So the result is that now it is possible to effectively cancel domain > creation while the bootloader is running. > > Signed-off-by: Ian Jackson Acked-by: Ian Campbell