From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbbCXPZ6 (ORCPT ); Tue, 24 Mar 2015 11:25:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41944 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752684AbbCXPZT (ORCPT ); Tue, 24 Mar 2015 11:25:19 -0400 Message-ID: <1427210714.18768.23.camel@nilsson.home.kraxel.org> Subject: Re: [virtio-dev] Re: [PATCH v3] Add virtio-input driver. From: Gerd Hoffmann To: "Michael S. Tsirkin" Cc: virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, David Herrmann , Dmitry Torokhov , Rusty Russell , open list , "open list:ABI/API" Date: Tue, 24 Mar 2015 16:25:14 +0100 In-Reply-To: <20150324143839-mutt-send-email-mst@redhat.com> References: <1427182321-19451-1-git-send-email-kraxel@redhat.com> <20150324105829-mutt-send-email-mst@redhat.com> <1427197581.18768.16.camel@nilsson.home.kraxel.org> <20150324135908-mutt-send-email-mst@redhat.com> <1427204244.18768.21.camel@nilsson.home.kraxel.org> <20150324143839-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Di, 2015-03-24 at 15:14 +0100, Michael S. Tsirkin wrote: > On Tue, Mar 24, 2015 at 02:37:24PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > input layer checks it and ignores events not supported (according to the > > > > support bitmaps). > > > > > > Right but support bitmaps come from host too, no? > > > > Yes, but the driver will not set invalid bits (bitcount argument for the > > virtinput_cfg_bits() function is the number of valid bits of the > > specific bitmap). > > > > cheers, > > Gerd > > > > > > > > Question: does linux ever get such events from userspace > as opposed to sending them to userspace? Yes, it's possible using the userspace input driver (CONFIG_INPUT_UINPUT) cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [virtio-dev] Re: [PATCH v3] Add virtio-input driver. Date: Tue, 24 Mar 2015 16:25:14 +0100 Message-ID: <1427210714.18768.23.camel@nilsson.home.kraxel.org> References: <1427182321-19451-1-git-send-email-kraxel@redhat.com> <20150324105829-mutt-send-email-mst@redhat.com> <1427197581.18768.16.camel@nilsson.home.kraxel.org> <20150324135908-mutt-send-email-mst@redhat.com> <1427204244.18768.21.camel@nilsson.home.kraxel.org> <20150324143839-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150324143839-mutt-send-email-mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" Cc: virtio-dev@lists.oasis-open.org, Dmitry Torokhov , "open list:ABI/API" , open list , virtualization@lists.linux-foundation.org, David Herrmann List-Id: linux-api@vger.kernel.org On Di, 2015-03-24 at 15:14 +0100, Michael S. Tsirkin wrote: > On Tue, Mar 24, 2015 at 02:37:24PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > input layer checks it and ignores events not supported (according to the > > > > support bitmaps). > > > > > > Right but support bitmaps come from host too, no? > > > > Yes, but the driver will not set invalid bits (bitcount argument for the > > virtinput_cfg_bits() function is the number of valid bits of the > > specific bitmap). > > > > cheers, > > Gerd > > > > > > > > Question: does linux ever get such events from userspace > as opposed to sending them to userspace? Yes, it's possible using the userspace input driver (CONFIG_INPUT_UINPUT) cheers, Gerd