From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753221AbbCYBf0 (ORCPT ); Tue, 24 Mar 2015 21:35:26 -0400 Received: from ozlabs.org ([103.22.144.67]:57982 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbbCYBfY (ORCPT ); Tue, 24 Mar 2015 21:35:24 -0400 Message-ID: <1427247322.29319.3.camel@ellerman.id.au> Subject: Re: [23/32] powerpc: copy_thread(): rename 'arg' argument to 'kthread_arg' From: Michael Ellerman To: Alex Dowad Cc: linux-kernel@vger.kernel.org, Michael Neuling , Paul Gortmaker , Paul Mackerras , Anton Blanchard , Vineeth Vijayan , Christoph Lameter , "open list:LINUX FOR POWERPC..." Date: Wed, 25 Mar 2015 12:35:22 +1100 In-Reply-To: <5511BFDF.6070309@gmail.com> References: <20150319064519.6BEA814010F@ozlabs.org> <550A794C.7020904@gmail.com> <1426809274.2581.0.camel@ellerman.id.au> <5511BFDF.6070309@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-03-24 at 21:49 +0200, Alex Dowad wrote: > On 20/03/15 01:54, Michael Ellerman wrote: > > On Thu, 2015-03-19 at 09:22 +0200, Alex Dowad wrote: > >> On 19/03/15 08:45, Michael Ellerman wrote: > >>> On Fri, 2015-13-03 at 18:14:46 UTC, Alex Dowad wrote: > >>>> The 'arg' argument to copy_thread() is only ever used when forking a new > >>>> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency > >>>> with do_fork() and other arch-specific implementations of copy_thread()). > >>> > >>> I don't understand the bit about consistency with do_fork() ? > >>> > >> This series of patches includes one patch which renames the arg for > >> do_fork(), and others which rename the same arg for each arch-specific > >> implementation of copy_thread(). So if all of them are accepted and > >> merged, then all will be consistent. If only some of the patches are > >> accepted, I will rewrite the commit message so it doesn't mention > >> "consistency". > > Ah OK, I only got patch 23, so I missed the context of the whole series. > > > > I'll apply this one to the powerpc tree. > > Dear M. Ellerman, sorry for not replying promptly. If you would like to > apply this directly to the powerpc tree, that is fine, but can I edit > the commit message to remove the mention of 'consistency'? I doubt that > all 30+ archs will ever merge this change. Thanks, Alex I merged it last week: https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/commit/?h=next&id=6eca8933d3ff17bff39d5f10a2a22366d8622fa6 And I edited the commit message more or less as you describe. And feel free to call me Michael or mpe :) cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 434C91A028E for ; Wed, 25 Mar 2015 12:35:23 +1100 (AEDT) Message-ID: <1427247322.29319.3.camel@ellerman.id.au> Subject: Re: [23/32] powerpc: copy_thread(): rename 'arg' argument to 'kthread_arg' From: Michael Ellerman To: Alex Dowad Date: Wed, 25 Mar 2015 12:35:22 +1100 In-Reply-To: <5511BFDF.6070309@gmail.com> References: <20150319064519.6BEA814010F@ozlabs.org> <550A794C.7020904@gmail.com> <1426809274.2581.0.camel@ellerman.id.au> <5511BFDF.6070309@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: Michael Neuling , linux-kernel@vger.kernel.org, Paul Gortmaker , Vineeth Vijayan , Anton Blanchard , Paul Mackerras , Christoph Lameter , "open list:LINUX FOR POWERPC..." List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2015-03-24 at 21:49 +0200, Alex Dowad wrote: > On 20/03/15 01:54, Michael Ellerman wrote: > > On Thu, 2015-03-19 at 09:22 +0200, Alex Dowad wrote: > >> On 19/03/15 08:45, Michael Ellerman wrote: > >>> On Fri, 2015-13-03 at 18:14:46 UTC, Alex Dowad wrote: > >>>> The 'arg' argument to copy_thread() is only ever used when forking a new > >>>> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and consistency > >>>> with do_fork() and other arch-specific implementations of copy_thread()). > >>> > >>> I don't understand the bit about consistency with do_fork() ? > >>> > >> This series of patches includes one patch which renames the arg for > >> do_fork(), and others which rename the same arg for each arch-specific > >> implementation of copy_thread(). So if all of them are accepted and > >> merged, then all will be consistent. If only some of the patches are > >> accepted, I will rewrite the commit message so it doesn't mention > >> "consistency". > > Ah OK, I only got patch 23, so I missed the context of the whole series. > > > > I'll apply this one to the powerpc tree. > > Dear M. Ellerman, sorry for not replying promptly. If you would like to > apply this directly to the powerpc tree, that is fine, but can I edit > the commit message to remove the mention of 'consistency'? I doubt that > all 30+ archs will ever merge this change. Thanks, Alex I merged it last week: https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/commit/?h=next&id=6eca8933d3ff17bff39d5f10a2a22366d8622fa6 And I edited the commit message more or less as you describe. And feel free to call me Michael or mpe :) cheers