* [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices @ 2015-03-25 6:53 rtatiya 2015-03-25 6:58 ` Greg KH [not found] ` <1427266399-19124-1-git-send-email-rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 0 siblings, 2 replies; 11+ messages in thread From: rtatiya @ 2015-03-25 6:53 UTC (permalink / raw) To: sarah.a.sharp, linux-usb; +Cc: linux-kernel, linux-arm-msm, Rupesh Tatiya From: Rupesh Tatiya <rtatiya@codeaurora.org> USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM. Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b Signed-off-by: Rupesh Tatiya <rtatiya@codeaurora.org> --- drivers/usb/core/hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 9ef2d2c..1ed7b5d 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -140,7 +140,7 @@ static int usb_device_supports_lpm(struct usb_device *udev) /* USB 2.1 (and greater) devices indicate LPM support through * their USB 2.0 Extended Capabilities BOS descriptor. */ - if (udev->speed == USB_SPEED_HIGH) { + if (udev->speed == USB_SPEED_HIGH || udev->speed == USB_SPEED_FULL) { if (udev->bos->ext_cap && (USB_LPM_SUPPORT & le32_to_cpu(udev->bos->ext_cap->bmAttributes))) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices 2015-03-25 6:53 [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices rtatiya @ 2015-03-25 6:58 ` Greg KH [not found] ` <20150325065824.GA25520-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> [not found] ` <1427266399-19124-1-git-send-email-rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 1 sibling, 1 reply; 11+ messages in thread From: Greg KH @ 2015-03-25 6:58 UTC (permalink / raw) To: rtatiya; +Cc: sarah.a.sharp, linux-usb, linux-kernel, linux-arm-msm On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya@codeaurora.org wrote: > From: Rupesh Tatiya <rtatiya@codeaurora.org> > > USB 2.01+ full-speed devices can have extended descriptor as well > and can support LPM. > > Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b We can't take patches with this in it, as it makes no sense in a kernel changelog :( ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20150325065824.GA25520-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices 2015-03-25 6:58 ` Greg KH @ 2015-04-08 11:27 ` rtatiya 0 siblings, 0 replies; 11+ messages in thread From: rtatiya-sgV2jX0FEOL9JmXXK+q4OQ @ 2015-04-08 11:27 UTC (permalink / raw) To: Greg KH Cc: rtatiya-sgV2jX0FEOL9JmXXK+q4OQ, sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA > On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote: >> From: Rupesh Tatiya <rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >> >> USB 2.01+ full-speed devices can have extended descriptor as well >> and can support LPM. >> >> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b > > We can't take patches with this in it, as it makes no sense in a kernel > changelog :( > > Sorry this is my first time (I read as much as I can before sending patch but not enough I guess). Should I remove "From" line or rephrase commit message? Thanks, Rupesh -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices @ 2015-04-08 11:27 ` rtatiya 0 siblings, 0 replies; 11+ messages in thread From: rtatiya @ 2015-04-08 11:27 UTC (permalink / raw) To: Greg KH; +Cc: rtatiya, sarah.a.sharp, linux-usb, linux-kernel, linux-arm-msm > On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya@codeaurora.org wrote: >> From: Rupesh Tatiya <rtatiya@codeaurora.org> >> >> USB 2.01+ full-speed devices can have extended descriptor as well >> and can support LPM. >> >> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b > > We can't take patches with this in it, as it makes no sense in a kernel > changelog :( > > Sorry this is my first time (I read as much as I can before sending patch but not enough I guess). Should I remove "From" line or rephrase commit message? Thanks, Rupesh ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices 2015-04-08 11:27 ` rtatiya (?) @ 2015-04-08 11:37 ` Greg KH -1 siblings, 0 replies; 11+ messages in thread From: Greg KH @ 2015-04-08 11:37 UTC (permalink / raw) To: rtatiya; +Cc: sarah.a.sharp, linux-usb, linux-kernel, linux-arm-msm On Wed, Apr 08, 2015 at 11:27:40AM -0000, rtatiya@codeaurora.org wrote: > > On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya@codeaurora.org wrote: > >> From: Rupesh Tatiya <rtatiya@codeaurora.org> > >> > >> USB 2.01+ full-speed devices can have extended descriptor as well > >> and can support LPM. > >> > >> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b > > > > We can't take patches with this in it, as it makes no sense in a kernel > > changelog :( > > > > > > Sorry this is my first time (I read as much as I can before sending patch > but not enough I guess). Should I remove "From" line or rephrase commit > message? >From line is fine. ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <6101704ff4dc2e95b67146ed26d01c9f.squirrel-mMfbam+mt9083fI46fginR2eb7JE58TQ@public.gmane.org>]
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices 2015-04-08 11:27 ` rtatiya @ 2015-04-08 13:24 ` gpramod -1 siblings, 0 replies; 11+ messages in thread From: gpramod-sgV2jX0FEOL9JmXXK+q4OQ @ 2015-04-08 13:24 UTC (permalink / raw) Cc: Greg KH, rtatiya-sgV2jX0FEOL9JmXXK+q4OQ, sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA >> On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote: >>> From: Rupesh Tatiya <rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> >>> >>> USB 2.01+ full-speed devices can have extended descriptor as well >>> and can support LPM. >>> >>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b >> >> We can't take patches with this in it, as it makes no sense in a kernel >> changelog :( >> >> > > Sorry this is my first time (I read as much as I can before sending patch > but not enough I guess). Should I remove "From" line or rephrase commit > message? Rupesh, Just remove below line from commit message: >>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b > > Thanks, > Rupesh > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices @ 2015-04-08 13:24 ` gpramod 0 siblings, 0 replies; 11+ messages in thread From: gpramod @ 2015-04-08 13:24 UTC (permalink / raw) To: rtatiya Cc: Greg KH, rtatiya, sarah.a.sharp, linux-usb, linux-kernel, linux-arm-msm >> On Wed, Mar 25, 2015 at 12:23:19PM +0530, rtatiya@codeaurora.org wrote: >>> From: Rupesh Tatiya <rtatiya@codeaurora.org> >>> >>> USB 2.01+ full-speed devices can have extended descriptor as well >>> and can support LPM. >>> >>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b >> >> We can't take patches with this in it, as it makes no sense in a kernel >> changelog :( >> >> > > Sorry this is my first time (I read as much as I can before sending patch > but not enough I guess). Should I remove "From" line or rephrase commit > message? Rupesh, Just remove below line from commit message: >>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b > > Thanks, > Rupesh > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - Pramod -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] usb: Enable LPM for USB 2.01+ full-speed devices 2015-04-08 11:27 ` rtatiya ` (2 preceding siblings ...) (?) @ 2015-04-14 11:06 ` Rupesh Tatiya -1 siblings, 0 replies; 11+ messages in thread From: Rupesh Tatiya @ 2015-04-14 11:06 UTC (permalink / raw) To: sarah.a.sharp, linux-usb, gregkh, oliver Cc: linux-kernel, linux-arm-msm, Rupesh Tatiya USB 2.01+ full-speed devices can have extended descriptor as well and can support LPM. Signed-off-by: Rupesh Tatiya <rtatiya@codeaurora.org> --- drivers/usb/core/hub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 9ef2d2c..1ed7b5d 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -140,7 +140,7 @@ static int usb_device_supports_lpm(struct usb_device *udev) /* USB 2.1 (and greater) devices indicate LPM support through * their USB 2.0 Extended Capabilities BOS descriptor. */ - if (udev->speed == USB_SPEED_HIGH) { + if (udev->speed == USB_SPEED_HIGH || udev->speed == USB_SPEED_FULL) { if (udev->bos->ext_cap && (USB_LPM_SUPPORT & le32_to_cpu(udev->bos->ext_cap->bmAttributes))) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <1427266399-19124-1-git-send-email-rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices 2015-03-25 6:53 [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices rtatiya @ 2015-03-25 8:41 ` Oliver Neukum [not found] ` <1427266399-19124-1-git-send-email-rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 1 sibling, 0 replies; 11+ messages in thread From: Oliver Neukum @ 2015-03-25 8:41 UTC (permalink / raw) To: rtatiya-sgV2jX0FEOL9JmXXK+q4OQ Cc: sarah.a.sharp-VuQAYsv1563Yd54FQh9/CA, linux-usb-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA On Wed, 2015-03-25 at 12:23 +0530, rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org wrote: > From: Rupesh Tatiya <rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> > > USB 2.01+ full-speed devices can have extended descriptor as well > and can support LPM. Yes, they in theory can, but what happens if they are actually asked to do so? On how many devices have you tested this patch? Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices @ 2015-03-25 8:41 ` Oliver Neukum 0 siblings, 0 replies; 11+ messages in thread From: Oliver Neukum @ 2015-03-25 8:41 UTC (permalink / raw) To: rtatiya; +Cc: sarah.a.sharp, linux-usb, linux-kernel, linux-arm-msm On Wed, 2015-03-25 at 12:23 +0530, rtatiya@codeaurora.org wrote: > From: Rupesh Tatiya <rtatiya@codeaurora.org> > > USB 2.01+ full-speed devices can have extended descriptor as well > and can support LPM. Yes, they in theory can, but what happens if they are actually asked to do so? On how many devices have you tested this patch? Regards Oliver ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices 2015-03-25 8:41 ` Oliver Neukum (?) @ 2015-04-08 11:24 ` rtatiya -1 siblings, 0 replies; 11+ messages in thread From: rtatiya @ 2015-04-08 11:24 UTC (permalink / raw) To: Oliver Neukum Cc: rtatiya, sarah.a.sharp, linux-usb, linux-kernel, linux-arm-msm >> >> USB 2.01+ full-speed devices can have extended descriptor as well >> and can support LPM. > > Yes, they in theory can, but what happens if they are actually > asked to do so? On how many devices have you tested this patch? > I have tested this on Qualcomm USB controller, LPM works. LPM works with same controller with Microsoft Windows as well. I have looked through few Broadcom/CSR controllers, but could not find one that had USB version >= 2.01. Thanks, Rupesh ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-04-14 11:07 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-03-25 6:53 [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices rtatiya 2015-03-25 6:58 ` Greg KH [not found] ` <20150325065824.GA25520-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> 2015-04-08 11:27 ` rtatiya-sgV2jX0FEOL9JmXXK+q4OQ 2015-04-08 11:27 ` rtatiya 2015-04-08 11:37 ` Greg KH [not found] ` <6101704ff4dc2e95b67146ed26d01c9f.squirrel-mMfbam+mt9083fI46fginR2eb7JE58TQ@public.gmane.org> 2015-04-08 13:24 ` gpramod-sgV2jX0FEOL9JmXXK+q4OQ 2015-04-08 13:24 ` gpramod 2015-04-14 11:06 ` [PATCH v2] " Rupesh Tatiya [not found] ` <1427266399-19124-1-git-send-email-rtatiya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-03-25 8:41 ` [PATCH] " Oliver Neukum 2015-03-25 8:41 ` Oliver Neukum 2015-04-08 11:24 ` rtatiya
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.