From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Williamson Subject: Re: [PATCH v4 4/4] drivers/vfio: Remove duplicated PE states Date: Wed, 25 Mar 2015 18:46:28 -0600 Message-ID: <1427330788.3643.883.camel@redhat.com> References: <1427325637-14345-1-git-send-email-gwshan@linux.vnet.ibm.com> <1427325637-14345-5-git-send-email-gwshan@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, kvm@vger.kernel.org, david@gibson.dropbear.id.au, agraf@suse.de To: Gavin Shan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42637 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbbCZAqa (ORCPT ); Wed, 25 Mar 2015 20:46:30 -0400 In-Reply-To: <1427325637-14345-5-git-send-email-gwshan@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2015-03-26 at 10:20 +1100, Gavin Shan wrote: > The set of constants for PE states defined in uapi/linux/vfio.h is > duplicated to uapi/asm/eeh.h. The patch removes the set from the > former. > > Signed-off-by: Gavin Shan > --- > include/uapi/linux/vfio.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index d81c17f..3fd1e86 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -492,11 +492,6 @@ struct vfio_eeh_pe_op { > #define VFIO_EEH_PE_UNFREEZE_IO 2 /* Enable IO for frozen PE */ > #define VFIO_EEH_PE_UNFREEZE_DMA 3 /* Enable DMA for frozen PE */ > #define VFIO_EEH_PE_GET_STATE 4 /* PE state retrieval */ > -#define VFIO_EEH_PE_STATE_NORMAL 0 /* PE in functional state */ > -#define VFIO_EEH_PE_STATE_RESET 1 /* PE reset in progress */ > -#define VFIO_EEH_PE_STATE_STOPPED 2 /* Stopped DMA and IO */ > -#define VFIO_EEH_PE_STATE_STOPPED_DMA 4 /* Stopped DMA only */ > -#define VFIO_EEH_PE_STATE_UNAVAIL 5 /* State unavailable */ > #define VFIO_EEH_PE_RESET_DEACTIVATE 5 /* Deassert PE reset */ > #define VFIO_EEH_PE_RESET_HOT 6 /* Assert hot reset */ > #define VFIO_EEH_PE_RESET_FUNDAMENTAL 7 /* Assert fundamental reset */ How do you know that nobody depends on these defines? I thought the suggestion was to use the EEH_* defines for error injection, not to remove existing VFIO_EEH_* defines. You could certainly redefine these in terms of EEH_* defines instead. Thanks, Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 7140D1A0671 for ; Thu, 26 Mar 2015 11:46:33 +1100 (AEDT) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id EA26814012C for ; Thu, 26 Mar 2015 11:46:32 +1100 (AEDT) Message-ID: <1427330788.3643.883.camel@redhat.com> Subject: Re: [PATCH v4 4/4] drivers/vfio: Remove duplicated PE states From: Alex Williamson To: Gavin Shan Date: Wed, 25 Mar 2015 18:46:28 -0600 In-Reply-To: <1427325637-14345-5-git-send-email-gwshan@linux.vnet.ibm.com> References: <1427325637-14345-1-git-send-email-gwshan@linux.vnet.ibm.com> <1427325637-14345-5-git-send-email-gwshan@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, agraf@suse.de, kvm@vger.kernel.org, david@gibson.dropbear.id.au List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2015-03-26 at 10:20 +1100, Gavin Shan wrote: > The set of constants for PE states defined in uapi/linux/vfio.h is > duplicated to uapi/asm/eeh.h. The patch removes the set from the > former. > > Signed-off-by: Gavin Shan > --- > include/uapi/linux/vfio.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index d81c17f..3fd1e86 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -492,11 +492,6 @@ struct vfio_eeh_pe_op { > #define VFIO_EEH_PE_UNFREEZE_IO 2 /* Enable IO for frozen PE */ > #define VFIO_EEH_PE_UNFREEZE_DMA 3 /* Enable DMA for frozen PE */ > #define VFIO_EEH_PE_GET_STATE 4 /* PE state retrieval */ > -#define VFIO_EEH_PE_STATE_NORMAL 0 /* PE in functional state */ > -#define VFIO_EEH_PE_STATE_RESET 1 /* PE reset in progress */ > -#define VFIO_EEH_PE_STATE_STOPPED 2 /* Stopped DMA and IO */ > -#define VFIO_EEH_PE_STATE_STOPPED_DMA 4 /* Stopped DMA only */ > -#define VFIO_EEH_PE_STATE_UNAVAIL 5 /* State unavailable */ > #define VFIO_EEH_PE_RESET_DEACTIVATE 5 /* Deassert PE reset */ > #define VFIO_EEH_PE_RESET_HOT 6 /* Assert hot reset */ > #define VFIO_EEH_PE_RESET_FUNDAMENTAL 7 /* Assert fundamental reset */ How do you know that nobody depends on these defines? I thought the suggestion was to use the EEH_* defines for error injection, not to remove existing VFIO_EEH_* defines. You could certainly redefine these in terms of EEH_* defines instead. Thanks, Alex