From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb0PR-0008EO-Vw for qemu-devel@nongnu.org; Thu, 26 Mar 2015 01:32:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yb0PL-0007FX-Ee for qemu-devel@nongnu.org; Thu, 26 Mar 2015 01:32:49 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:41873) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb0PK-0007F5-MI for qemu-devel@nongnu.org; Thu, 26 Mar 2015 01:32:43 -0400 From: zhanghailiang Date: Thu, 26 Mar 2015 13:29:11 +0800 Message-ID: <1427347774-8960-6-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1427347774-8960-1-git-send-email-zhang.zhanghailiang@huawei.com> References: <1427347774-8960-1-git-send-email-zhang.zhanghailiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [RFC PATCH v4 05/28] migration: Integrate COLO checkpoint process into loadvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, dgilbert@redhat.com, zhanghailiang , arei.gonglei@huawei.com, amit.shah@redhat.com, Lai Jiangshan , Yang Hongyang , david@gibson.dropbear.id.au Switch from normal migration loadvm process into COLO checkpoint process if COLO mode is enabled. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Lai Jiangshan Signed-off-by: Yang Hongyang --- include/migration/migration-colo.h | 13 +++++++++++++ migration/colo-comm.c | 10 ++++++++++ migration/colo.c | 14 ++++++++++++++ migration/migration.c | 21 ++++++++++++++++++++- stubs/migration-colo.c | 5 +++++ 5 files changed, 62 insertions(+), 1 deletion(-) diff --git a/include/migration/migration-colo.h b/include/migration/migration-colo.h index cac23e1..b326c35 100644 --- a/include/migration/migration-colo.h +++ b/include/migration/migration-colo.h @@ -15,11 +15,24 @@ #include "qemu-common.h" #include "migration/migration.h" +#include "block/coroutine.h" +#include "qemu/thread.h" bool colo_supported(void); void colo_info_mig_init(void); +struct colo_incoming { + QEMUFile *file; + QemuThread thread; +}; + void colo_init_checkpointer(MigrationState *s); bool migrate_in_colo_state(void); +/* loadvm */ +extern Coroutine *migration_incoming_co; +bool loadvm_enable_colo(void); +void loadvm_exit_colo(void); +void *colo_process_incoming_checkpoints(void *opaque); +bool loadvm_in_colo_state(void); #endif diff --git a/migration/colo-comm.c b/migration/colo-comm.c index cab97e9..1d844e1 100644 --- a/migration/colo-comm.c +++ b/migration/colo-comm.c @@ -53,3 +53,13 @@ void colo_info_mig_init(void) register_savevm_live(NULL, "colo", -1, 1, &savevm_colo_info_handlers, NULL); } + +bool loadvm_enable_colo(void) +{ + return colo_requested; +} + +void loadvm_exit_colo(void) +{ + colo_requested = false; +} diff --git a/migration/colo.c b/migration/colo.c index d8cab6d..3b6fbf2 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -24,6 +24,7 @@ } while (0) static QEMUBH *colo_bh; +static Coroutine *colo; bool colo_supported(void) { @@ -81,3 +82,16 @@ void colo_init_checkpointer(MigrationState *s) colo_bh = qemu_bh_new(colo_start_checkpointer, s); qemu_bh_schedule(colo_bh); } + +void *colo_process_incoming_checkpoints(void *opaque) +{ + colo = qemu_coroutine_self(); + assert(colo != NULL); + + /* TODO: COLO checkpoint restore loop */ + + colo = NULL; + loadvm_exit_colo(); + + return NULL; +} diff --git a/migration/migration.c b/migration/migration.c index d904c4d..26bf235 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -96,6 +96,7 @@ void qemu_start_incoming_migration(const char *uri, Error **errp) } } +Coroutine *migration_incoming_co; static void process_incoming_migration_co(void *opaque) { QEMUFile *f = opaque; @@ -103,7 +104,25 @@ static void process_incoming_migration_co(void *opaque) int ret; ret = qemu_loadvm_state(f); - qemu_fclose(f); + + /* we get colo info, and know if we are in colo mode */ + if (loadvm_enable_colo()) { + struct colo_incoming *colo_in = g_malloc0(sizeof(*colo_in)); + + colo_in->file = f; + migration_incoming_co = qemu_coroutine_self(); + qemu_thread_create(&colo_in->thread, "colo incoming", + colo_process_incoming_checkpoints, colo_in, QEMU_THREAD_JOINABLE); + qemu_coroutine_yield(); + migration_incoming_co = NULL; +#if 0 + /* FIXME wait checkpoint incoming thread exit, and free resource */ + qemu_thread_join(&colo_in->thread); + g_free(colo_in); +#endif + } else { + qemu_fclose(f); + } free_xbzrle_decoded_buf(); if (ret < 0) { error_report("load of migration failed: %s", strerror(-ret)); diff --git a/stubs/migration-colo.c b/stubs/migration-colo.c index 495ca28..cbadcd6 100644 --- a/stubs/migration-colo.c +++ b/stubs/migration-colo.c @@ -25,3 +25,8 @@ bool migrate_in_colo_state(void) void colo_init_checkpointer(MigrationState *s) { } + +void *colo_process_incoming_checkpoints(void *opaque) +{ + return NULL; +} -- 1.7.12.4