All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Stone <daniels@collabora.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer
Date: Thu, 26 Mar 2015 14:48:27 +0000	[thread overview]
Message-ID: <1427381307.28393.10@mail.collabora.com> (raw)
In-Reply-To: <5514187E.60405@samsung.com>


[-- Attachment #1.1: Type: text/plain, Size: 1621 bytes --]

Hi Inki,

On Thu, 26 Mar, 2015 at 2:32 PM, Inki Dae <inki.dae@samsung.com> wrote:
> Applied.

Thanks very much.

> Could you use right prefix of the subject like below when you post 
> patch?
> 
> 'drm/exynos: ...', not 'drm: Exynos: ...'
> 
> Your email will be filtered from my mailbox if you don't use the right
> prefix so I couldn't check and take care of your patch.

Ah, I didn't realise this. Maybe it could be good to not filter if the 
patch is also directly addressed/CCed to you, rather than a list? 
Gustavo Padovan is following this convention and I also will in future, 
but I guess it might lead to some patches being dropped from casual 
contributors if they don't know this.

Cheers,
Daniel

> 
> Thanks,
> Inki Dae
> 
> On 2015년 03월 24일 17:57, Javier Martinez Canillas wrote:
>>  Hello Inki,
>> 
>>  On Tue, Mar 17, 2015 at 2:24 PM, Daniel Stone 
>> <daniels@collabora.com> wrote:
>>>  When performing a modeset, use the framebuffer pitch value to set 
>>> FIMD
>>>  IMG_SIZE and Mixer SPAN registers. These are both defined as pitch 
>>> - the
>>>  distance between contiguous lines (bytes for FIMD, pixels for 
>>> mixer).
>>> 
>>>  Fixes display on Snow (1366x768).
>>> 
>>>  Signed-off-by: Daniel Stone <daniels@collabora.com>
>>>  Tested-by: Javier Martinez Canillas 
>>> <javier.martinez@collabora.co.uk>
>> 
>>  Any comments on this patch? It would be great to pick this sooner
>>  rather than later since it fixes (at least) display output on Snow 
>> and
>>  HDMI output on Peach Pit/Pi.
>> 
>>  Best regards,
>>  Javier
>> 
> 
> 

[-- Attachment #1.2: Type: text/html, Size: 2073 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-03-26 14:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 13:24 [PATCH] drm: Exynos: Respect framebuffer pitch for FIMD/Mixer Daniel Stone
2015-03-24  8:57 ` Javier Martinez Canillas
2015-03-26 14:32   ` Inki Dae
2015-03-26 14:48     ` Daniel Stone [this message]
2015-03-27  1:55       ` Inki Dae
2015-03-27  0:15     ` Tobias Jakobi
2015-03-27  1:47       ` Inki Dae
2015-03-27 11:08         ` Javier Martinez Canillas
2015-03-27 16:28           ` Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1427381307.28393.10@mail.collabora.com \
    --to=daniels@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=inki.dae@samsung.com \
    --cc=javier@dowhile0.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.