From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753003AbbCZUxh (ORCPT ); Thu, 26 Mar 2015 16:53:37 -0400 Received: from mga09.intel.com ([134.134.136.24]:36527 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752930AbbCZUxg (ORCPT ); Thu, 26 Mar 2015 16:53:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,474,1422950400"; d="scan'208";a="704775715" Message-ID: <1427403214.29730.3.camel@theros.lm.intel.com> Subject: Re: [PATCH 2/3] x86: add a is_e820_ram() helper From: Ross Zwisler To: Christoph Hellwig Cc: Boaz Harrosh , Ingo Molnar , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, axboe@kernel.dk Date: Thu, 26 Mar 2015 14:53:34 -0600 In-Reply-To: <20150326164314.GB23958@lst.de> References: <1427358764-6126-1-git-send-email-hch@lst.de> <1427358764-6126-3-git-send-email-hch@lst.de> <20150326090215.GA11520@gmail.com> <20150326093424.GA28217@lst.de> <55142A92.4060607@plexistor.com> <20150326164314.GB23958@lst.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20.rez) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-03-26 at 17:43 +0100, Christoph Hellwig wrote: > On Thu, Mar 26, 2015 at 05:49:38PM +0200, Boaz Harrosh wrote: > > > +#define E820_PRAM 12 > > > > Why the PRAM Name. For one 2/3 of this patch say PMEM the Kconfig > > to enable is _PMEM_, the driver stack that gets loaded is pmem, > > so PRAM is unexpected. > > > > Also I do believe PRAM is not the correct name. Yes NvDIMMs are RAM, > > but there are other not RAM technologies that can be supported exactly > > the same way. > > MEM is a more general name meaning "on the memory bus". I think. > > > > I would love the consistency. > > Ingo asked for the PRAM name, I don't really care either way. I also prefer "E820_PMEM", fwiw.