From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932078AbbCZWW0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Mar 2015 18:22:26 -0400
Received: from mga11.intel.com ([192.55.52.93]:49101 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752435AbbCZWWX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Mar 2015 18:22:23 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,475,1422950400"; 
   d="scan'208";a="686271168"
Message-ID: <1427408542.29730.13.camel@theros.lm.intel.com>
Subject: Re: [PATCH] SQUASHME: Streamline pmem.c
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Boaz Harrosh <boaz@plexistor.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-nvdimm@ml01.01.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        x86@kernel.org, axboe@kernel.dk
Date: Thu, 26 Mar 2015 16:22:22 -0600
In-Reply-To: <55143B99.7060407@plexistor.com>
References: <1427358764-6126-1-git-send-email-hch@lst.de>
	 <55143A8B.2060304@plexistor.com> <55143B99.7060407@plexistor.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20.rez) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-03-26 at 19:02 +0200, Boaz Harrosh wrote:
>  static void pmem_do_bvec(struct pmem_device *pmem, struct page *page,
>  			unsigned int len, unsigned int off, int rw,
>  			sector_t sector)
>  {
>  	void *mem = kmap_atomic(page);
> +	size_t pmem_off = sector << 9;
> +
> +	BUG_ON(pmem_off >= pmem->size);

This check should take 'len' into account so we don't copy off the end of our
PMEM space.

We should also just return -EIO back up to pmem_make_request() and have that
fail the bio, as opposed to doing the drastic BUG_ON.