From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932215AbbC0M2i (ORCPT ); Fri, 27 Mar 2015 08:28:38 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:18667 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932199AbbC0M2g (ORCPT ); Fri, 27 Mar 2015 08:28:36 -0400 X-AuditID: cbfec7f4-b7f126d000001e9a-3f-55154c4901c9 From: Krzysztof Kozlowski To: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Olof Johansson , Marek Szyprowski , Krzysztof Kozlowski Subject: [PATCH v2 3/3] ARM: EXYNOS: Add missing of_node_put() when parsing power domains Date: Fri, 27 Mar 2015 13:28:25 +0100 Message-id: <1427459305-26625-3-git-send-email-k.kozlowski@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1427459305-26625-1-git-send-email-k.kozlowski@samsung.com> References: <1427459305-26625-1-git-send-email-k.kozlowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHJMWRmVeSWpSXmKPExsVy+t/xq7qePqKhBuv28Fr8nXSM3eL1C0OL /sevmS02Pb7GanF51xw2ixnn9zFZrD1yl93i1PXPbA4cHr9/TWL02LSqk81j85J6jysnmlg9 +rasYvT4vEkugC2KyyYlNSezLLVI3y6BK2PVwmmMBSd4Krb09bM1MLZzdTFyckgImEisffWS HcIWk7hwbz0biC0ksJRRomOFZBcjF5DdxyQx4/djZpAEm4CxxOblS9hAEiICXYwSs7b8Butg FljEKLHkojOILSwQLbFibxcTiM0ioCrxp+MaWDOvgLvEwaYrUNvkJE4em8wKYnMKeEjcvbKW EWKzu8S9WbfYJzDyLmBkWMUomlqaXFCclJ5rqFecmFtcmpeul5yfu4kREmZfdjAuPmZ1iFGA g1GJh9fgoHCoEGtiWXFl7iFGCQ5mJRFefhfRUCHelMTKqtSi/Pii0pzU4kOMTBycUg2MbGmv PtfNcHx28Idf48zTB+W/R10355dtlpcMezq/Vm22RvYyG9nz9SuW/Iwrnr5u9g5hd/EK5bM+ TcvVCvewfEq6a8k9+Y1OYdkUz2sfpjWEn4y7ZSzl8L41blaQzLJl05fvSZ1v+lWF1Tbv8x4B 1wU6bIzvU3Qb7YxmseZ/3LS94ovDzSgOJZbijERDLeai4kQAouIf9RECAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add missing of_node_put() to: 1. Error return path if allocating memory for exynos_pm_domain failed. 2. Second iteration over power domains if a child domain was not present or was incomplete. Signed-off-by: Krzysztof Kozlowski Reported-by: Karol Wrona --- Changes since v1: 1. New patch. --- arch/arm/mach-exynos/pm_domains.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 61c32ccc9f7a..1a90c5da2fd7 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -138,6 +138,7 @@ static __init int exynos4_pm_init_power_domain(void) if (!pd) { pr_err("%s: failed to allocate memory for domain\n", __func__); + of_node_put(np); return -ENOMEM; } @@ -209,15 +210,15 @@ no_clk: args.args_count = 0; child_domain = of_genpd_get_from_provider(&args); if (!child_domain) - continue; + goto next_pd; if (of_parse_phandle_with_args(np, "power-domains", "#power-domain-cells", 0, &args) != 0) - continue; + goto next_pd; parent_domain = of_genpd_get_from_provider(&args); if (!parent_domain) - continue; + goto next_pd; if (pm_genpd_add_subdomain(parent_domain, child_domain)) pr_warn("%s failed to add subdomain: %s\n", @@ -225,6 +226,7 @@ no_clk: else pr_info("%s has as child subdomain: %s.\n", parent_domain->name, child_domain->name); +next_pd: of_node_put(np); } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Fri, 27 Mar 2015 13:28:25 +0100 Subject: [PATCH v2 3/3] ARM: EXYNOS: Add missing of_node_put() when parsing power domains In-Reply-To: <1427459305-26625-1-git-send-email-k.kozlowski@samsung.com> References: <1427459305-26625-1-git-send-email-k.kozlowski@samsung.com> Message-ID: <1427459305-26625-3-git-send-email-k.kozlowski@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Add missing of_node_put() to: 1. Error return path if allocating memory for exynos_pm_domain failed. 2. Second iteration over power domains if a child domain was not present or was incomplete. Signed-off-by: Krzysztof Kozlowski Reported-by: Karol Wrona --- Changes since v1: 1. New patch. --- arch/arm/mach-exynos/pm_domains.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 61c32ccc9f7a..1a90c5da2fd7 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -138,6 +138,7 @@ static __init int exynos4_pm_init_power_domain(void) if (!pd) { pr_err("%s: failed to allocate memory for domain\n", __func__); + of_node_put(np); return -ENOMEM; } @@ -209,15 +210,15 @@ no_clk: args.args_count = 0; child_domain = of_genpd_get_from_provider(&args); if (!child_domain) - continue; + goto next_pd; if (of_parse_phandle_with_args(np, "power-domains", "#power-domain-cells", 0, &args) != 0) - continue; + goto next_pd; parent_domain = of_genpd_get_from_provider(&args); if (!parent_domain) - continue; + goto next_pd; if (pm_genpd_add_subdomain(parent_domain, child_domain)) pr_warn("%s failed to add subdomain: %s\n", @@ -225,6 +226,7 @@ no_clk: else pr_info("%s has as child subdomain: %s.\n", parent_domain->name, child_domain->name); +next_pd: of_node_put(np); } -- 1.9.1