From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbbC2R7v (ORCPT ); Sun, 29 Mar 2015 13:59:51 -0400 Received: from smtprelay0156.hostedemail.com ([216.40.44.156]:45687 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752334AbbC2R7t (ORCPT ); Sun, 29 Mar 2015 13:59:49 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:968:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2559:2562:2828:2911:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:4425:5007:6248:6261:7875:7903:10004:10400:10848:11232:11658:11914:12296:12517:12519:12740:13069:13071:13311:13357:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: stem94_8f9f251b34b06 X-Filterd-Recvd-Size: 2435 Message-ID: <1427651985.2715.39.camel@perches.com> Subject: Re: [PATCH 00/86] pci: export pci_ids.h and related cleanups From: Joe Perches To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Bjorn Helgaas Date: Sun, 29 Mar 2015 10:59:45 -0700 In-Reply-To: <1427635734-24786-1-git-send-email-mst@redhat.com> References: <1427635734-24786-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2015-03-29 at 15:36 +0200, Michael S. Tsirkin wrote: > The macros in pci_ids.h are pretty useful for userspace > using the pci sysfs interface, e.g. to decode class > device and vendor sysfs files. > > At the moment userspace is forced to duplicate these macros (e.g. QEMU does > this, so does gpxe, seabios, etc), it is better to export them in > /usr/include/linux/pci_ids.h so everyone can just include this header. > > This patchset is structured as follows: > 1. include/linux/pci_ids.h is moved to include/uapi/linux/pci_ids.h; > a stub file is created in include/linux/pci_ids.h to avoid breaking > bisect > 2. all users are converted to use the new header > 3. include/linux/pci_ids.h is removed > 4. cleanups for several issues detected during step 2 > > The patchset was built on several architectures (mips/ppc/x86), > boot-tested on x86 only - build seems sufficient for this kind of > change. > > I think the pci tree is the most appropriate for this patchset. > Please review it, and consider for 4.1. Hello again Michael. It's nicer if you send this cover letter to all mailing lists that receive any of the individual patches so that people can reply to the 0/n patch and a single discussion thread can happen for generic issues for the entire patchset. It'd be even nicer to cc all of the maintainers of any of the sections modified, but vger mailing lists reject any email with more than 2k of email headers. Unfortunately, patchsets for multiple subsystems create long cc lists that generally exceed this limit.