From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: REGRESSION [PATCH v2 08/13] libxc: Check
 xc_domain_maximum_gpfn for negative return values
Date: Mon, 30 Mar 2015 09:49:04 +0100
Message-ID: <1427705344.13935.206.camel@citrix.com>
References: <20150319185416.GC21217@x230.dumpdata.com>
	<1426844888.21742.107.camel@citrix.com>
	<20150320143434.GD17267@l.oracle.com>
	<20150320144925.GA22093@l.oracle.com>
	<1426863624.21742.213.camel@citrix.com>
	<20150320154555.GD2085@l.oracle.com>
	<1426870986.21742.226.camel@citrix.com> <551474F9.5060705@citrix.com>
	<20150327194230.GA6873@l.oracle.com> <5515B7DC.9060300@citrix.com>
	<20150327204146.GB27867@l.oracle.com> <5515C8D7.6060304@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1YcVNf-0003go-JR
	for xen-devel@lists.xenproject.org; Mon, 30 Mar 2015 08:49:11 +0000
In-Reply-To: <5515C8D7.6060304@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-03-27 at 21:17 +0000, Andrew Cooper wrote:
> > -int xc_domain_maximum_gpfn(xc_interface *xch, domid_t domid, xen_pfn_t *gpfns);
> > +int xc_domain_maximum_gpfn(xc_interface *xch, domid_t domid);
> 
> It is perfectly fine for xc_domain_maximum_gpfn() to keep its *gpfn
> pointer, as this is a rather more sane interface which doesn't truncate
> the hypervisor long in a 64bit toolstack.

Ack. FAOD the two interfaces should be:
int xc_domain_maximum_gpfn(xc_interface *xch, domid_t domid, xen_pfn_t *gpfns);
int xc_domain_nr_gpfns(xc_interface *xch, domid_t domid, xen_pfn_t *gpfns);

Ian.