From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Ycm2k-0001mG-OX
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 22:36:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Ycm2g-0008C2-9B
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 22:36:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45423)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1Ycm2g-0008Bw-4N
	for qemu-devel@nongnu.org; Mon, 30 Mar 2015 22:36:38 -0400
Date: Tue, 31 Mar 2015 10:36:26 +0800
From: Jason Wang <jasowang@redhat.com>
Message-Id: <1427769386.11302.3@smtp.corp.redhat.com>
In-Reply-To: <20150320123333.54cb602d.cornelia.huck@de.ibm.com>
References: <1426671309-13645-1-git-send-email-jasowang@redhat.com>
	<1426671309-13645-11-git-send-email-jasowang@redhat.com>
	<20150320123333.54cb602d.cornelia.huck@de.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Subject: Re: [Qemu-devel] [PATCH V4 10/19] virtio-ccw: introduce ccw
	specific queue limit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Alexander Graf <agraf@suse.de>, Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>, mst@redhat.com



On Fri, Mar 20, 2015 at 7:33 PM, Cornelia Huck 
<cornelia.huck@de.ibm.com> wrote:
> On Wed, 18 Mar 2015 17:35:00 +0800
> Jason Wang <jasowang@redhat.com> wrote:
> 
>>  Instead of depending on marco, using a bus specific limit.
> 
> You should probably also mention the adapter routes change in your
> changelog:
> 
> "Also make it clear that the number of gsis per I/O adapter is not
> directly depending on the number of virtio queues, but rather the 
> other
> way around."

Will add this in next version.
> 
>>  
>>  Cc: Alexander Graf <agraf@suse.de>
>>  Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
>>  Cc: Christian Borntraeger <borntraeger@de.ibm.com>
>>  Cc: Richard Henderson <rth@twiddle.net>
>>  Signed-off-by: Jason Wang <jasowang@redhat.com>
>>  ---
>>   hw/s390x/s390-virtio-ccw.c   |  7 +++++--
>>   hw/s390x/virtio-ccw.c        | 19 ++++++++++++-------
>>   include/hw/s390x/s390_flic.h |  4 +++-
>>   3 files changed, 20 insertions(+), 10 deletions(-)
>>  
> 
> Looks good to me.

Thanks