From: Alex Williamson <alex.williamson@redhat.com>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
Cc: aik@ozlabs.ru, david@gibson.dropbear.id.au, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device
Date: Tue, 31 Mar 2015 12:17:52 -0600 [thread overview]
Message-ID: <1427825872.5567.177.camel@redhat.com> (raw)
In-Reply-To: <1427352132-1762-1-git-send-email-nikunj@linux.vnet.ibm.com>
On Thu, 2015-03-26 at 12:12 +0530, Nikunj A Dadhania wrote:
> From PCIDevice there is no way to know if the device has a backing
> vfio device.
>
> sPAPR guests inherits the "ibm,loc-code" from the pci pass through
> device in hypervisor. This helps in identifying the device if there is
> any failures using this "ibm,loc-code" for RAS capabilities.
>
> CC: Alex Williamson <alex.williamson@redhat.com>
> CC: Alexander Graf <agraf@suse.de>
> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
> ---
> hw/vfio/pci.c | 2 ++
> include/hw/pci/pci.h | 2 ++
> 2 files changed, 4 insertions(+)
I agree with the other comments on this series, the vfio information can
be found using existing object and property functions. Nak to the vfio
related changes. Also, please us cover letters for multi-patch series.
Thanks,
Alex
next prev parent reply other threads:[~2015-03-31 18:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 6:42 [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device Nikunj A Dadhania
2015-03-26 6:42 ` [Qemu-devel] [PATCH 2/2] spapr: populate ibm,loc-code Nikunj A Dadhania
2015-03-27 3:16 ` Alexey Kardashevskiy
2015-03-27 4:29 ` Nikunj A Dadhania
2015-03-27 6:21 ` Nikunj A Dadhania
2015-03-27 6:38 ` Alexey Kardashevskiy
2015-03-27 3:28 ` David Gibson
2015-03-27 3:58 ` Alexey Kardashevskiy
2015-03-27 4:34 ` Nikunj A Dadhania
2015-03-27 4:57 ` David Gibson
2015-03-27 6:24 ` Nikunj A Dadhania
2015-03-27 3:05 ` [Qemu-devel] [PATCH 1/2] vfio-pci: add flag to identify vfio pci device Alexey Kardashevskiy
2015-03-31 18:17 ` Alex Williamson [this message]
2015-04-01 5:05 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427825872.5567.177.camel@redhat.com \
--to=alex.williamson@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.